Add dependency on minitest-mock for MT6 compatibility#137
Merged
voxik merged 1 commit intofedora-ruby:masterfrom Jan 7, 2026
Merged
Add dependency on minitest-mock for MT6 compatibility#137voxik merged 1 commit intofedora-ruby:masterfrom
voxik merged 1 commit intofedora-ruby:masterfrom
Conversation
voxik
force-pushed
the
minitest6-compat
branch
from
dd9dc9f to
6c69553
Compare
Member
Author
And that is not possible unfortunately :/ |
voxik
force-pushed
the
minitest6-compat
branch
5 times, most recently
from
3a739ac to
b3dfe3f
Compare
This prevents test errors with minitest 6+ such as:
~~~
2) Error:
TestGem2Rpm#test_show_templates:
NoMethodError: undefined method 'stub' for class Gem2Rpm::Distro
test/test_gem2rpm.rb:40:in 'TestGem2Rpm#test_show_templates'
~~~
This is due to minitest-mock being extracted from Minitest 6+:
minitest/minitest@de9aac1
This change unfortunately requies Bundler to be used to execute test
suite, because:
1. RubyGems cannot load minitest-mock [[1]]
2. MT6 restrict support to Ruby 3.2+ [[2], [3]]
I wish the use of Bundler can be reverted one day.
[1]: ruby/rubygems#9238
[2]: minitest/minitest-mock#4
[3]: minitest/minitest#1058
voxik
force-pushed
the
minitest6-compat
branch
from
b3dfe3f to
44e345a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents test errors with minitest 6+ such as:
This is due to minitest-mock being extracted from Minitest 6+:
minitest/minitest@de9aac1
Theoretically, the dependency could be conditionalized, but lets keep things simple.