updpatch: gitlab 17.10.1-1#4635
Conversation
| bundle config --local deployment true | ||
| bundle config --local without 'development test aws kerberos' | ||
| + # override nokogiri build flags | ||
| + bundle config --local build.nokogiri "--use-system-libraries --enable-shared --disable-static --with-cflags='-O2'" |
There was a problem hiding this comment.
Wondering if this should be upstreamed to Arch Linux. 🤔
There was a problem hiding this comment.
this change is from observing arch's own ruby-nokogiri's building process, i have no idea why upstream archlinux doesn't meet this error.
originally inside gitlab: --disable-shared --enable-static CFLAGS=-fPIC
arch ruby-nokogiri alone: --enable-shared --disable-static
upd:
maybe they met some similar? as
bundle config --local build.gpgme --use-system-libraries # See https://bugs.archlinux.org/task/63654
bundle config --local build.re2 --enable-system-libraries # See https://gitlab.archlinux.org/archlinux/packaging/packages/gitlab/-/issues/5
There was a problem hiding this comment.
Hello again. I don't know if upstreaming it to arch linux is up to the code of conduct, because according to investigation, x86 uses the prebuilt gem, so they are not compiling it natively. Adding this line to x86 build does no difference, the upside is that it will not affect the compiling behaviour, the downside, however, is that it is actually a meaningless line on x86 packing process.
|
I'm merging now. But in the long run it would still be better to try to resolve it on upstream side. There are multiple ways forward (and they are not conflicting each other!):
|
3 participants
rbtracepatch is modified because compiling should not be in the prepare() part