Feature: Add DSEA projection#1
Conversation
|
@felixpalmer Would it be a good time to rebase/update these extra features on top of the main polyhedral PR while we wait for the workflows to be approved? It would help to see how easy it is to add these extra polyhedra. I'm curious about how hard it would be to add the Truncated Icosahedron in particular (TISEA / TIVEA) :) |
|
@jerstlouis well, DSEA & ISEA have already been moved into the main PR, so we can close these extra ones. IVEA & TISEA I don't want to tackle right now as it'll complicate the already large PR. Could you confirm everything looks good in that main PR now? I can then do a pass and update the description and docs and then we can mark it as ready for reivew Spoilers though, I have prototyped TISEA ;)
|
|
Closing as root PR includes DSEA |
I haven't looked at every single line or tested compiling or running it myself, but it does all look very good. One thing: since you've demonstrated parity with the existing ISEA projection, could we maybe just replace Especially if you're able to test the specific issue in OSGeo#4389 with Also I still hope to do a future PR with the improved formulas possibly avoiding trigonometry and achieving greater precision (and at that point we can then change the round-trip tolerance from 0.2 mm to 23 nanometers). (also in your current description you have 1 nm -- I would remove that, as the current tests don't demonstrate that, and I don't think that is true at the more tricky locations near the vertices and edges). Maybe also remove the mentions of PR 2 and 3 that are now closed from the description? |
|
@felixpalmer Very cool for the TISEA prototype, but the face numbering is not quite right yet :) (Compared to Figure 4). |
😆 close enough for now |


Overview
This PR is stacked on top of the root PR: OSGeo#4758 - please see there before reviewing
Adds support for the
DSEAprojection (the dodecahedral equivalent ofISEA), along with a number of output net configurations. TheDSEAprojection is used in https://a5geo.org/ and has lower deformation than more widely usedISEAprojection.Change list
DSEA:decakis_dodecahedron.hnets/dsea/***.hExample renders
DSEA