Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: djsConfig not updating because component is looking at old props #204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: djsConfig not updating because component is looking at old props #204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/react-dropzone.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,14 +100,14 @@ export class DropzoneComponent extends React.Component {
* React 'componentWillUpdate'
* Update Dropzone options each time the component updates.
*/
componentWillUpdate () {
componentWillUpdate (nextProps) {
let djsConfigObj
let postUrlConfigObj

djsConfigObj = this.props.djsConfig ? this.props.djsConfig : {}
djsConfigObj = nextProps.djsConfig ? nextProps.djsConfig : {}
Copy link
Contributor

@DanielRuf DanielRuf Oct 11, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically this should be like before. But there should be a strict equality comparison for the current and new config, like nextProps.djsConfig !== this.props.djsConfig.

Becuase this might not work on the initial render and it makes sense to keep the current logic to prevent any regressions.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think componentWillUpdate gets called on the initial render - although you didn't say 'mount' so maybe i'm missing something.

I could see wrapping the whole thing in that strict equality comparison to make sure this doesn't run unless either of those 2 specific props changed - for performance reasons. Is that what you're looking for?

As far as i can tell there is no reason you would ever want to run the update with the old props like it is doing today.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use extend() to merge them.

I am not completely sure, also because this lifecycle method is deprecated in React 16 because of cases where it is always called.


try {
postUrlConfigObj = this.props.config.postUrl ? { url: this.props.config.postUrl } : {}
postUrlConfigObj = nextProps.config.postUrl ? { url: nextProps.config.postUrl } : {}
} catch (err) {
postUrlConfigObj = {}
}
Expand Down