Make Sass implementation agnostic ( supporting dart-sass )#17
Make Sass implementation agnostic ( supporting dart-sass )#17fsubal wants to merge 4 commits intofetch:masterfrom
Conversation
| }) | ||
| }) | ||
| }) | ||
| describe.each(['node-sass', 'sass'])('with require("%s")', function(impl) { |
There was a problem hiding this comment.
Currently installed version of jest did not support describe.each, so I updated jest
There was a problem hiding this comment.
Just for the record, the test failure was not due to the jest version ( it also failed with jest@16.0.2 with ['node-sass', 'sass'].forEach instead of describe.each )
|
Love this, can we get it merged @koenpunt ? |
koenpunt
left a comment
koenpunt
left a comment
There was a problem hiding this comment.
I see I still have a pending review comment here.
| options = options || {} | ||
| options.images_path = __dirname + '/images' | ||
| options.fonts_path = __dirname + '/fonts' | ||
| options.implemantation = sass |
There was a problem hiding this comment.
| options.implemantation = sass | |
| options.implementation = sass |
|
hey folks, can this PR get merged in? would be super helpful since node-sass is basically decrepit at this point |
|
for those who want to install this now |
|
I've released a new version to npm that replaces |
3 participants
Resolves: #16
I made this library to be sass-implementation agnostic, that means, add support for
dart-sass.With these changes, node-sass-asset-functions now accepts
implementationoption ( which exceptsrequire('node-sass')orrequire('sass'), and when absent it will be implicitlynode-sass)For some reason the test is not passing ( Maybe
dart-sasscannot read file correctly, even though the path looks correct ), which is now I'm searching why... Help wanted by someone.