Conversation
|
I appreciate the effort, but there's really too much going in this PR; formatting, code style, more modern javascript language constructs, etc. The code formatting for example is probably based on some auto formatting, but there doesn't seem to be a configuration for it. If any I would prefer Prettier to be used for formatting. But it has been a long time since I worked on this project, and going through the code myself I see quite some things I would've done differently now. But I'm not using it anywhere anymore, so I don't really have bandwidth to work on it. And large PRs like this one makes it hard to review in a timely fashion.. If you're okay with maybe splitting it into several PRs, for example first updating the code style (with a file dictating or enforcing the style), and then one with the actual changes it would make it much easier for me to review. |
|
I appreciate your thoughts on this. I submitted this PR to 'pay it back', and reflects work I did to keep this functionality alive in my own sass toolchains. It's required, bc the types returned by node-sass are not compatible with current sass (where all the feature work is being done). My work is publicly available in NPM as package However, as this package still gets ~5k downloads a week, I thought it could be beneficial for people by extending that upgrade path within this library. Perhaps a new package is the best path forward. Thanks again for creating this library. |
|
I've released a new version to npm that replaces |
A 1.0.0 proposal
sassoption