Skip to content

Persist popup open/close state to avoid closing it every page refresh #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Persist popup open/close state to avoid closing it every page refresh #419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27f61cf
Update App.ce.vue
vbrajon Dec 13, 2024
4e9395f
Update App.ce.vue
vbrajon Feb 21, 2025
a00d6d6
Update test.spec.ts
vbrajon May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/runtime/src/App.ce.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,11 @@ if (props?.overlayConfig?.initialIsOpen === 'error') {
})
}

const userCollapsed = ref<boolean | undefined>(undefined)
const userCollapsed = ref<boolean>(sessionStorage.vite_checker_overlay_collapsed === "true")

const toggle = () => {
userCollapsed.value = !(userCollapsed.value ?? initialCollapsed.value)
sessionStorage.vite_checker_overlay_collapsed = userCollapsed.value
}

const collapsed = computed<boolean>(() => userCollapsed.value ?? initialCollapsed.value)
Expand Down
1 change: 1 addition & 0 deletions playground/config-initialIsOpen-error/__tests__/test.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ describe('config-initialIsOpen-error', () => {
console.log('-- overlay remains after fix error --')
editFile('src/main.ts', (code) => code.replace('var hello', `const hello`))
await sleepForEdit()
await sleep(6000)
await pollingUntil(getHmrOverlay, (dom) => !!dom)
const [, , frame2] = await getHmrOverlayText()
expect(frame2).toMatchSnapshot()
Expand Down
Loading