Skip to content

Add the get_github_release script to entry-points so it can be used #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2018

Conversation

mortenlj
Copy link
Member

@mortenlj mortenlj commented Jan 5, 2018

Until we can replace it, the get_github_release script needs to be installed alongside the publish command, because we need to download github-release before running publish.

@mortenlj mortenlj requested a review from oyvindio January 5, 2018 11:33
Copy link
Member

@oyvindio oyvindio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mortenlj
Copy link
Member Author

mortenlj commented Jan 5, 2018

Nice comment from Codacy:

setup.py is often changed in this project

Considering this is the third PR, and this is the third commit on the file, I guess they are sort of right... :D

@mortenlj
Copy link
Member Author

mortenlj commented Jan 5, 2018

I don't understand why Codacy is still Pending, according to Codacy it's completed and rated A.
I'm going to merge it anyway.

@mortenlj mortenlj merged commit a5a692e into master Jan 5, 2018
@mortenlj mortenlj deleted the publishing branch January 5, 2018 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants