Skip to content

Fix warnings from GHA checks #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Aug 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
6f457ff
Script to find upgradeable patterns (#534)
spier May 12, 2023
5c3eb97
shared-code-repo-different-from-build-repo.md - Moved to InnerSource …
MaineC May 12, 2023
903c68c
Removing link to innersourceportal.santander.com (#539)
spier May 20, 2023
1d27905
Adding vale for spell and style checking (#519)
spier May 22, 2023
59c01a9
Writing updated files for the book
spier May 22, 2023
db15ee1
Board Report 2023-05 (#540)
spier May 25, 2023
4afeec8
Fixing link (#545)
spier Jun 16, 2023
9635fc4
Re-creating markmap and screenshot
spier Jun 16, 2023
b27512e
Add i18n consistency-checker
yuhattor Jun 18, 2023
fccd62b
Update to use i18n label for internationalization related issue
yuhattor Jun 18, 2023
55cbbc9
Initial Japanese Translation - extensions-for-sustainable-growth pattern
yuhattor Jun 18, 2023
2ccf254
Update links
yuhattor Jun 18, 2023
59b5a11
Update the wiki link to pass the link check
yuhattor Jun 18, 2023
94a5aae
Update Label Type - i18n-consistency-checker.yaml
yuhattor Jun 19, 2023
845cb29
Update Airbus implementation of the innersource portal pattern (#550)
sicot-f Jun 20, 2023
279c99f
Update translation/ja/patterns/extensions-for-sustainable-growth.md
yuhattor Jun 21, 2023
9abad41
Update translation/ja/patterns/extensions-for-sustainable-growth.md
yuhattor Jun 21, 2023
32f2860
Update translation/ja/patterns/extensions-for-sustainable-growth.md
yuhattor Jun 21, 2023
6c4c03f
Update translation/ja/patterns/extensions-for-sustainable-growth.md
yuhattor Jun 21, 2023
9941e90
Update translation/ja/patterns/extensions-for-sustainable-growth.md
yuhattor Jun 21, 2023
0266cca
Incorporated the review
yuhattor Jun 21, 2023
ab1cce3
Update Japanese translation
yuhattor Jun 21, 2023
11bc7eb
Update base-documentation.md, fix CONTRIBUTING spelling (#552)
jeffabailey Jun 26, 2023
243f4bc
Create COMMUNICATION-template.md (#557)
kschueths Jul 5, 2023
e936f17
Add Known Instance to service-vs-library.md (#559)
rrrutledge Jul 17, 2023
a171116
Update translation/ja/patterns/extensions-for-sustainable-growth.md
yuhattor Jul 19, 2023
cc8dc8f
Update translation/ja/patterns/extensions-for-sustainable-growth.md
yuhattor Jul 19, 2023
506cebf
Merge pull request #549 from InnerSourceCommons/adding-extensions-for…
yuhattor Jul 19, 2023
44fab36
Add Mercedes-Benz as known instance to innersource-portal.md (#561)
spier Jul 24, 2023
516a887
Use glob to select files to be checked by vale (#541)
spier Aug 2, 2023
ac724fc
Bump semver from 5.7.1 to 5.7.2 in /pattern-categorization (#558)
dependabot[bot] Aug 2, 2023
370cc98
Adding welcome bot + fix links to slack (#567)
spier Aug 9, 2023
9c3697a
Move Release Process pattern to L2 (Structured) (#524)
dgrizzanti Aug 9, 2023
3a50380
Writing updated files for the book
spier Aug 9, 2023
7aa4e06
Add GitHub to release-process as a known instance (#568)
zkoppert Aug 9, 2023
d8f253c
Re-creating markmap and screenshot
spier Aug 9, 2023
e744a71
Remove outdated link to 'release process' pattern. this has been upgr…
spier Aug 16, 2023
84aac4f
As this branch was far behind main, I am bringing in the latest changes.
spier Aug 16, 2023
75327fb
Switch to AE spelling
spier Aug 16, 2023
92e13ac
Prefent spell checker warnings on author names
spier Aug 16, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
blank_issues_enabled: true
contact_links:
- name: Slack
url: https://innersourcecommons-inviter.herokuapp.com
url: https://innersourcecommons.org/slack
about: Join our Community on Slack for help and a casual chat.
- name: Patterns Book
url: https://patterns.innersourcecommons.org
Expand Down
44 changes: 44 additions & 0 deletions .github/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
# Configuration for welcome - https://github.com/behaviorbot/welcome

# Configuration for new-issue-welcome - https://github.com/behaviorbot/new-issue-welcome

# Comment to be posted to on first time issues
newIssueWelcomeComment: >
[![Welcome Banner](https://zenodo.org/api/iiif/v2/0c0188d3-d03c-4830-a6e3-00405f5c22fa:8ff47a85-7250-4d86-8e48-2f346b48b2c1:BannerWelcome.jpg/full/750,/0/default.jpg)](https://zenodo.org/record/3695300)

:tada: Welcome to _The InnerSource Commons_ community, and in particular to our patterns! :tada:
We're really excited to have your input into the project! :sparkling_heart:

<br>If you haven't done so already, please check out our [Contributing Guidelines](https://github.com/InnerSourceCommons/InnerSourcePatterns/blob/main/CONTRIBUTING.md).
If you need to connect more synchronously with members of _The InnerSource Commons_ community, come chat with us in our [Slack workspace](https://innersourcecommons.org/slack).

# Configuration for new-pr-welcome - https://github.com/behaviorbot/new-pr-welcome

# Comment to be posted to on PRs from first time contributors in your repository
newPRWelcomeComment: >
[![Thank You Banner](https://zenodo.org/api/iiif/v2/0c0188d3-d03c-4830-a6e3-00405f5c22fa:7fbd97cf-283b-480c-b8e1-11866e26245c:BannerThanks.jpg/full/750,/0/default.jpg)](https://zenodo.org/record/3695300)

:sparkling_heart: Thanks for opening this pull request! :sparkling_heart:
_The InnerSource Commons_ community really appreciates your time and effort to contribute to the project.
Please make sure you have read our [Contributing Guidelines](https://github.com/InnerSourceCommons/InnerSourcePatterns/blob/main/CONTRIBUTING.md).

If you are submitting a new pattern, the following things will help get your pull request across the finish line! :checkered_flag:

- Check you have used our [pattern template](https://github.com/InnerSourceCommons/InnerSourcePatterns/blob/main/meta/pattern-template.md) and removed any placeholder text and sections that your pattern did not need.

- We will run a number of automated checks on your PR. Please review the output of those checks on the PR itself, and see if any issues got flagged that you can fix yourself.

- Make sure you have added your new pattern to the list of patterns in the main [README.md](https://github.com/InnerSourceCommons/InnerSourcePatterns/blob/main/README.md). If you are unsure where to add your pattern, no worries. Just let us know on the PR and we will help you.

<br>This project has a small number of maintainers, volunteering their time to this project. So please be patient and we will get back to you as soon as we can.
If we don't acknowledge this pull request after 7 days, feel free to chat to us about it in our [Slack workspace](https://innersourcecommons.org/slack).

# Configuration for first-pr-merge - https://github.com/behaviorbot/first-pr-merge

# Comment to be posted to on pull requests merged by a first time user
firstPRMergeComment: >
[![Congratulations Banner](https://zenodo.org/api/iiif/v2/0c0188d3-d03c-4830-a6e3-00405f5c22fa:32fbdb89-ae1b-434e-830c-88ade86724cc:BannerCongratulations.jpg/full/750,/0/default.jpg)](https://zenodo.org/record/3695300)

Congrats on merging your first pull request! :tada:
We here at _The InnerSource Commons_ are proud of you! :sparkling_heart:
Thank you so much for your contribution :gift:
File renamed without changes.
File renamed without changes.
6 changes: 6 additions & 0 deletions .github/vale/Vocab/Base/accept.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Manoj
Gawande
Dinesh
Ramadoss
Amit
Chauhan
Empty file.
104 changes: 104 additions & 0 deletions .github/workflows/i18n-consistency-checker.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,104 @@
name: i18n check consistency and notify on GitHub Issues

on:
pull_request:
branches:
- master
paths:
- .github/workflows/i18n-consistency-check.yml
schedule:
- cron: '0 0 1 * *'
workflow_dispatch:

jobs:
consistency-check:
runs-on: ubuntu-latest
strategy:
matrix:
language: [ja, zh]
steps:
- uses: actions/checkout@v2
with:
fetch-depth: '0'
- name: Check consistency
id: check-consistency
run: |
# Set the issue header
issue="\
# i18n Contents Consistency Issue\\n\
\\n\
The following files may have consistency issues with the English version. Please check and update the files.\\n\
\\n\
This issue is created when there is an update to content/en. It compares the git update history to let you know what updates are overdue. The issue should be closed when the update is complete.\\n"

for file in $(find patterns/2-structured -name '*.md'); do

# Get the translated file name and check if it exists
i18n_filename=$(echo "$file" | sed 's/patterns\/2-structured/translation\/${{matrix.language}}\/patterns/g')
if [[ ! -e "$i18n_filename" ]]; then
continue
fi
echo $file
echo $i18n_filename
# Loop through all the files in the English directory
# Get the last updated date of the original file and the translated file
original_updated_at=$(date -d "$(git log -1 --format=%cd --date=iso $file)" +%s)
i18n_content_updated_at=$(date -d "$(git log -1 --format=%cd --date=iso $i18n_filename)" +%s)

# print the last updated date of the original file and the translated file

# Check if the translated file is updated after the original file
if [[ $(($original_updated_at - $i18n_content_updated_at)) -ge 1 ]]; then
# Get the title of the content
content_header=$(echo "$(cat "$file")" | grep -E '^title+' | sort -r | head -n1)
content_title=$(echo "$content_header" | sed 's/title: //g')

# Get the days since the translated file is overdue
days_since_overdue_updates=$(($(( $(date +%s) - $original_updated_at))/ 60 / 60 / 24))
# Get the diff between the original file and the translated file
original_last_update_hash=$(git log -1 --format=%H $file)
# Get the parent hash of the original last update hash
parent_hash=$(git log -1 --format=%P $original_last_update_hash)
# Get the diff between the original file and the translated file

result=$(echo "$(git diff ${parent_hash} HEAD $file)" | sed '1,4 s/^/# /')
echo -e "$result"

# Add the contents to the issue.md file
issue+="<details><summary><b>$content_title</b> ($file)</summary>\\n\\n"
issue+="- Original File(en): [$file](https://github.com/$GITHUB_REPOSITORY/blob/master/$file)\\n"
issue+="- Translated File(${{matrix.language}}): [$i18n_filename](https://github.com/$GITHUB_REPOSITORY/blob/master/$i18n_filename)\\n"
issue+="- [Diff on GitHub](https://github.com/yuhattor/innersourcecommons.org/compare/$i18n_last_update_hash...$original_last_update_hash)\\n"
issue+="- Days since overdue updates: $days_since_overdue_updates days\\n"
issue+="\`\`\`diff\\n"
issue+="$result"
issue+="\\n\`\`\`\\n"
issue+="</details>\\n"
echo -e "$issue" >> issue.md
issue=""
fi
done
- name: Create Issue
run: |
# Declare the flags
declare -A flags=(
["ja"]="🇯🇵 Japanese"
["zh"]="🇨🇳 Chinese"
)

# Set the issue title
issue_title="${flags[${{matrix.language}}]}: Content Consistency Issue"

# Get the existing issue ID
existing_issue_id=$(gh issue list -S "state:open type:issue title:$issue_title" | cut -f1)

# If the issue.md file exists, create a new issue or comment on the existing issue
if [ -f issue.md ]; then
if expr "$existing_issue_id" : '^[0-9]*$' >/dev/null; then
gh issue comment "$existing_issue_id" -F issue.md -R $GITHUB_REPOSITORY
else
gh issue create -t "$issue_title" -F issue.md -R $GITHUB_REPOSITORY -l "Type - Translation"
fi
fi
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
8 changes: 5 additions & 3 deletions .github/workflows/lint-patterns.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# from: https://github.com/marketplace/actions/markdown-linting-action
# To test this locally, switch to the root of the repo and run:
# markdownlint -r config/lint/pattern-template.js -c config/lint/pattern-template.yml patterns/2-structured/*.md patterns/2-structured/project-setup/*.md patterns/3-validated/*.md
name: Pattern Syntax Validation

on:
Expand All @@ -8,7 +10,7 @@ on:
pull_request:
paths:
- ".github/workflows/lint-patterns.yml"
- "lint/*"
- ".github/lint-pattern-syntax/*"
- "patterns/2-structured/*.md"
- "patterns/2-structured/project-setup/*.md"
- "patterns/3-validated/*.md"
Expand All @@ -23,6 +25,6 @@ jobs:
- name: Lint pattern files (markdown)
uses: avto-dev/markdown-lint@v1
with:
rules: './lint/pattern-template.js'
config: './lint/pattern-template.yml'
rules: './.github/lint-pattern-syntax/pattern-template.js'
config: './.github/lint-pattern-syntax/pattern-template.yml'
args: 'patterns/2-structured/*.md patterns/2-structured/project-setup/*.md patterns/3-validated/*.md'
26 changes: 26 additions & 0 deletions .github/workflows/vale.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
name: Spelling & Styles

on:
push:
branches:
- main
paths:
- '**.md'
pull_request:
branches:
- main

jobs:
vale:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3

- name: Vale Linting
uses: errata-ai/vale-action@reviewdog
with:
files: '["patterns/2-structured/", "patterns/3-validated/"]'
vale_flags: "--glob=*.md"
filter_mode: added
debug: true
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# We want to ignore our vale StylesPath
.github/vale/*
3 changes: 2 additions & 1 deletion .lycheeignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@ https://example.com/link/to/your/trusted/committer/documentation.md
https://github.com/rcs/rcs-viewer/pull/81
http://creativecommons.org/licenses
https://isc-inviter.herokuapp.com
https://innersourcecommons-inviter.herokuapp.com
fearlesschangepatterns.com
https://ulir.ul.ie/bitstream/handle/10344/4443/Stol_2014_inner.pdf
.*@andrew.clegg.*
https://m.dotdev.co/how-to-write-a-readme-that-rocks-bc29f279611a
https://innersourcecommons-inviter.herokuapp.com
https://www.chathamhouse.org/about-us/chatham-house-rule
12 changes: 12 additions & 0 deletions .vale.ini
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
StylesPath = .github/vale
MinAlertLevel = suggestion

Packages = https://github.com/InnerSourceCommons/isc-styles/releases/latest/download/ISC.zip

Vocab = Base

[*]
BasedOnStyles = ISC

; If you **don't** want to check for the correct spelling of "InnerSource", comment this in
; ISC.InnerSource = NO
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ We are happy to support you in contributing to the InnerSource patterns or to ju

You can best reach out to us **via Slack**:

Join the InnerSource Commons [Slack instance](https://isc-inviter.herokuapp.com/) and enter the `#innersource-patterns` channel there.
Join the InnerSource Commons [Slack instance](https://innersourcecommons.org/slack) and enter the `#innersource-patterns` channel there.

## License of Contributions

Expand Down
Loading