Skip to content

[4.x] Allow hiding specific error notifications#19400

Open
coleshirley wants to merge 3 commits intofilamentphp:4.xfrom
coleshirley:allow-hiding
Open

[4.x] Allow hiding specific error notifications#19400
coleshirley wants to merge 3 commits intofilamentphp:4.xfrom
coleshirley:allow-hiding

Conversation

@coleshirley
Copy link
Contributor

Description

Allow error notifications with certain status codes to be hidden. This is useful for utilizing the built in filament error notifications for the majority of errors but implementing custom logic for specific http status codes

Visual changes

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@github-project-automation github-project-automation bot moved this to Todo in Roadmap Mar 3, 2026
@danharrin danharrin added enhancement New feature or request pending review labels Mar 4, 2026
@danharrin danharrin added this to the v4 milestone Mar 4, 2026
Copy link
Member

@danharrin danharrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the naming here. "Hidden" to me feels like the error is still caught (and doesn't show the error modal) but there isn't an error notification either. But in your implementation, the error modal isn't prevented. Maybe we need both options, with the current implementation being called something else. Thoughts?

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Roadmap Mar 4, 2026
@coleshirley
Copy link
Contributor Author

coleshirley commented Mar 4, 2026

That makes sense. What do you think about bypassErrorHandling or skipErrorHandling for the current logic and then hideErrorNotification does what you suggest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request pending changes

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants