Add loading indicator SVG configuration#19434
Closed
Shaharyar-WebDev wants to merge 1 commit intofilamentphp:4.xfrom
Closed
Add loading indicator SVG configuration#19434Shaharyar-WebDev wants to merge 1 commit intofilamentphp:4.xfrom
Shaharyar-WebDev wants to merge 1 commit intofilamentphp:4.xfrom
Conversation
Added configuration option for custom loading indicator SVG. Signed-off-by: Shaharyar Ahmed <shery.codes@gmail.com>
Member
|
Changes need to be in one PR #19435, as one should not be merged without the other |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added configuration option for custom loading indicator SVG.
Description
Previously, the loading indicator SVG was hardcoded and could not be
customized without modifying the package source. This adds a
loading_indicator_svgkey to the config file, allowing users todefine their own SVG icon for the loading indicator.
The
__attributes__placeholder is injected into the SVG at runtime,so dynamic attributes (e.g.
wire:loading,class) are still appliedcorrectly regardless of which SVG is used.
Visual changes
Before (Default Loader):
After (Lucide Loader):
Functional changes
composer cscommand.