FRC-0104: add ChainGetFinalizedTipSet #1199
Merged
+669
−639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `ChainGetFinalizedTipSet` given it's addition to Lotuvs `/v1` in filecoin-project/lotus#13299
BigLep
requested review from
TippyFlitsUK,
anorth,
dannyob,
jennijuju,
jsoares,
lanzafame,
momack2 and
rvagg
as code owners
There was a problem hiding this comment.
LGTM. @AlexeyKrasnoperov could you help @BigLep with updating the spec once we agree this is good to go?
jsoares
approved these changes
Sep 22, 2025
AlexeyKrasnoperov
requested changes
Sep 23, 2025
rvagg
approved these changes
Sep 23, 2025
4 tasks
|
The updated common-node-api.json: It has some additional changes to the format, that's how Forest now exports it. |
|
^ json lgtm, should be incorporated here too @BigLep when you next get around to updating this PR |
Co-authored-by: Alexey Krasnoperov <[email protected]>
|
Comments incporated. I also added the updated common-node-api.json. Per @AlexeyKrasnoperov : "The format slightly changed since the last export, that's why the diff with the original common-node-api.json from FIP-0104 is bigger than just that one method." |
AlexeyKrasnoperov
approved these changes
Oct 21, 2025
github-project-automation
bot
moved this from ⌨️ In Progress
to ✔️ Approved by reviewer
in FilOz
github-project-automation
bot
moved this from ✔️ Approved by reviewer
to 🎉 Done
in FilOz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
ChainGetFinalizedTipSetto FRC-0104 given it's addition to Lotuvs/v1in filecoin-project/lotus#13299.If this idea is accepted, then can do the other work for this FRC to document its acceptance like updating https://github.com/filecoin-project/FIPs/tree/master/resources/frc-0104