Feature: Added support for Sync drive#16947
Feature: Added support for Sync drive#16947Lamparter wants to merge 3 commits intofiles-community:mainfrom
Conversation
|
I'm unsure exactly how Sync cloud drive works, but since it's incredibly easy to implement I've done it based on what I understand from #16935 |
| { | ||
| Name = $"Sync - {folder.Name}", | ||
| SyncFolder = directory, | ||
| // IconData = (needs icon) |
There was a problem hiding this comment.
There one in the install location C:\Program Files (x86)\Sync\folder.ico
| { | ||
| protected override async IAsyncEnumerable<ICloudProvider> GetProviders() | ||
| { | ||
| string syncFolderPath = Path.Combine(Constants.UserEnvironmentPaths.HomePath, "Sync"); |
There was a problem hiding this comment.
If you change the path in the installer, this would not work.
I think it would be better to modify the DetectGenericCloudDrive method. This method detects the existing cloud drives from the registry. I think that only small changes need to be made so that the SyncDrive is also recognized.
yair100
added
changes requested
yair100
force-pushed
the
main
branch
7 times, most recently
from
30cea65 to
decf3da
Compare
Signed-off-by: Lamparter <71598437+Lamparter@users.noreply.github.com>
Signed-off-by: Lamparter <71598437+Lamparter@users.noreply.github.com>
| { | ||
| protected override async IAsyncEnumerable<ICloudProvider> GetProviders() | ||
| { | ||
| string syncFolderPath = Path.Combine(Constants.UserEnvironmentPaths.HomePath, "Sync"); |
There was a problem hiding this comment.
It isn't showing the cloud drive for me. The sync folder is in %userprofile%\Sync .
The storage location can also be changed by the user, although I haven't found out where to get it from since it not the registry marcofranzen99 found where it is in the last screenshot
There was a problem hiding this comment.
I'm aware of this, I haven't gotten round to migrating to finding the path in the Registry yet.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
The PR isn't ready just yet |
yair100
force-pushed
the
main
branch
2 times, most recently
from
75d29b5 to
aa7d7fa
Compare
|
Superseded by #17116 |
|
@Lamparter thank you for your work on this PR. |
5 participants
Resolved / Related Issues
Steps used to test these changes