Code Quality: Categorize package dependencies for better tracking of AOT safety#18738
Code Quality: Categorize package dependencies for better tracking of AOT safety#187380x5bfa wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors centrally managed NuGet package versions to group dependencies by category (to help track AOT safety), and removes the unused Dongle.GuidRVAGen dependency from the CsWin32 project.
Changes:
- Reorganized
Directory.Packages.propsinto labeled dependency sections and removedDongle.GuidRVAGenfrom central package version management. - Removed
Dongle.GuidRVAGen(and also removed existing project references) fromFiles.App.CsWin32.csproj.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Files.App.CsWin32/Files.App.CsWin32.csproj | Drops Dongle.GuidRVAGen and removes existing project references from the CsWin32 project file. |
| Directory.Packages.props | Adds category headers for package versions, reorders entries, and removes Dongle.GuidRVAGen from central versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afa920f4db
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Resolved / Related Issues
Please check the
Directory.Packages.propsdiff thoroughlyDongle.GuidRVAGenfor being unusedSteps used to test these changes
None.