Skip to content

Add ContextWithMetadata to IntentResult - #2020

Merged
kriswest merged 5 commits into
mainfrom
agent/add-context-with-metadata-to-intent-result
Aug 13, 2026
Merged

Add ContextWithMetadata to IntentResult#2020
kriswest merged 5 commits into
mainfrom
agent/add-context-with-metadata-to-intent-result

Conversation

@julianna-ciq

Copy link
Copy Markdown
Contributor

What changed

  • Added ContextWithMetadata to the TypeScript IntentResult union.
  • Updated the matching API reference documentation.

Why

The IntentResult documentation explains that intent handlers may return ContextWithMetadata, but the documented and exported TypeScript union omitted it. This made the type declaration inconsistent with the supported handler result described immediately below it.

Impact

TypeScript consumers can now use ContextWithMetadata as an IntentResult, and the published API reference accurately reflects the union.

Validation

  • npm test --workspace packages/fdc3-standard — 5 test files passed, 14 tests passed.
  • git diff --check

@netlify

netlify Bot commented Jul 23, 2026

Copy link
Copy Markdown

Deploy Preview for fdc3 ready!

Name Link
🔨 Latest commit ac1610f
🔍 Latest deploy log https://app.netlify.com/projects/fdc3/deploys/6a7c83535d7b5800088dfea7
😎 Deploy Preview https://deploy-preview-2020.preview-fdc3.finos.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@julianna-ciq
julianna-ciq marked this pull request as ready for review July 23, 2026 15:06
@julianna-ciq
julianna-ciq requested a review from a team as a code owner July 23, 2026 15:06

@kriswest kriswest left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently fixing this causing an example app to blow up as its expecting a type property on a non-void result (both channel and context have type). So a legitimate build fail apparently.

See the netlify build log: server-apps/security-demo-app1/src/app1.ts

@codecov-commenter

codecov-commenter commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.11%. Comparing base (9436683) to head (ac1610f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2020   +/-   ##
=======================================
  Coverage   95.10%   95.11%           
=======================================
  Files          73       73           
  Lines        4190     4196    +6     
  Branches      670      581   -89     
=======================================
+ Hits         3985     3991    +6     
  Misses        205      205           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@julianna-ciq
julianna-ciq requested a review from kriswest July 31, 2026 13:46
@kriswest

Copy link
Copy Markdown
Contributor

Apologies this has picked up a couple of conflicts in need of manual resolution

…h-metadata-to-intent-result

# Conflicts:
#	website/docs/api/ref/Metadata.md
#	website/docs/api/ref/Types.md
@kriswest

Copy link
Copy Markdown
Contributor

RE-review after rebase so we can read the docs

@kriswest

Copy link
Copy Markdown
Contributor

Need to address go and .NET type defintions to deal with IntentResolutionResult. Their definitions will be different...
Lets Build the IntentResolutionResult type rather than using a typescript utility type to do it, as that will better match up across languages....

@kriswest
kriswest marked this pull request as draft August 12, 2026 13:48
@julianna-ciq
julianna-ciq marked this pull request as ready for review August 12, 2026 18:22

@kriswest kriswest left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but doesn't address the .NET and go binding updates fully. We can deal with that during the final pass for .NET and Go to sync them with FDC3 3.0 (@kemerava @bingenito)

@kriswest
kriswest merged commit 4a363e3 into main Aug 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants