fix(web-impl): decouple heartbeat timeouts - #2030
Open
emerardd wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
emerardd
marked this pull request as ready for review
July 24, 2026 03:20
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2030 +/- ##
========================================
Coverage 95.48% 95.48%
========================================
Files 85 85
Lines 6705 6712 +7
Branches 790 1047 +257
========================================
+ Hits 6402 6409 +7
Misses 303 303 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
This decouples the FDC3 for Web reference server's heartbeat timings from its open-handler timeout.
heartbeats: truenow usesHeartbeatHandler's existing 5s/30s/60s defaults regardless ofopenHandlerTimeoutMs.HeartbeatOptionsobject to configurepingInterval,disconnectedAfter, anddeadAfterindependently.Related Issue
Resolves #1678.
Contributor License Agreement
Validation
npm test --workspace @finos/fdc3-web-impl(109 tests passed, 97.06% coverage)..\..\..\node_modules\.bin\vitest.cmd run test\features\heartbeat.feature(3 tests passed)npm run lint --workspace @finos/fdc3-web-implgit diff --checkReview Checklist
DesktopAgent,Channel,PrivateChannel,Listener, orBridgingAPI is changed; this affects only the Web reference implementation server constructor.