Skip to content

Ben Page Product & Observable Model - Removal of Choice Type Extension#4771

Open
regnosys-prod-user wants to merge 4 commits into
finos:masterfrom
rosetta-models:benja_68bf072695eb9eb85b2ae7e-CER
Open

Ben Page Product & Observable Model - Removal of Choice Type Extension#4771
regnosys-prod-user wants to merge 4 commits into
finos:masterfrom
rosetta-models:benja_68bf072695eb9eb85b2ae7e-CER

Conversation

@regnosys-prod-user
Copy link
Copy Markdown
Collaborator

No description provided.

@regnosys-prod-user regnosys-prod-user requested a review from a team as a code owner May 28, 2026 09:40
@regnosys-prod-user
Copy link
Copy Markdown
Collaborator Author

Product & Observable Model - Removal of Choice Type Extension

Background

As part of the DSL 10.0.0 CDM upgrade, legacy syntax validation warnings need to promoted to errors

What is being released?

Changing the following extensions to attributes under the types: - BasketConstituent extends Observable. - SpecificAsset extends Asset. - TransferableProduct extends Asset. And resolving any code breaks where the attribute now needs to be added

Review Directions

Changes can be reviewed in PR: #4771

Note

This comment was generated via Rosetta.

@regnosys-prod-user regnosys-prod-user added the Rosetta Pull requests which can be viewed in Rosetta label May 28, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 28, 2026

Deploy Preview for finos-cdm ready!

Name Link
🔨 Latest commit 800b345
🔍 Latest deploy log https://app.netlify.com/projects/finos-cdm/deploys/6a18281015b4e70007644abf
😎 Deploy Preview https://deploy-preview-4771--finos-cdm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ReleaseManagement-BP ReleaseManagement-BP changed the title Ben Page Product & Observable Model - Removal of Choice Type Extension Ben Page Product & Observable Model - Removal of Choice Type Extension May 28, 2026
@@ -221,16 +221,6 @@
"collateralPosition" : [ {
"product" : {
"TransferableProduct" : {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all of these TransferableProduct definitions the asset needs to be specified so needs to be replaced with a TransferableProduct -> asset rather than removed.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a issue with the test pack creator. I've assigned this to the tech team to resolve this, and should be resolved under #4772

AssetAgencyRating <"Criteria is the agency rating(s) of the collateral asset.">
AssetMaturity <"Criteria is the maturity characteristics of the collateral asset.">
SpecificAsset <"Criteria is a specifically identified asset">
AssetIdentifier <"Criteria is a specifically identified asset">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

full stop on the end of the comment please

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change made on #4772

@regnosys-prod-user
Copy link
Copy Markdown
Collaborator Author

What is being released?

Accidentally removed set on basketConstituent

Note

This comment was generated via Rosetta.

@regnosys-prod-user regnosys-prod-user added Rosetta Pull requests which can be viewed in Rosetta and removed Rosetta Pull requests which can be viewed in Rosetta labels May 28, 2026
ReleaseManagement-BP pushed a commit to rosetta-models/common-domain-model that referenced this pull request May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Rosetta Pull requests which can be viewed in Rosetta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove ability to extend a choice type

4 participants