Maintain @finos/perspective TypeScript Compatibility for Clientside Environments
#2928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores the
typesfield that was removed from this package'spackage.jsonin 7c134b3, directing to the "browser" typedef. Removing this field causes compatibility issues with projects that use the "node" algorithm for tsconfig'smoduleResolution, which includes all NextJS projects.Heads up: one outstanding issue in the current release version of perspective-js (i.e. unrelated to this PR) is that the referenced typedef for Node isn't actually created, and attempting to import from
@finos/perspective/nodeindeed does not work for me.