Python AsyncClient and JS ProxySession #2929
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support in perspective-js for creating proxy sessions from a connected client. Signed-off-by: Tom Jakubowski <[email protected]>
tomjakubowski
force-pushed
the
feature/py-async-client
branch
from
65c8f99 to
4b2fbce
Compare
* Support for running maturin commands with uv
* set `PSP_UV=1` in environment
* use `uv venv` to create venv, then activate it
* `uv pip install -r **/requirements.txt` to install requirements
* Update pyo3 from 0.21 to 0.23
* this was to support use of the `pyo3-async-runtimes` crate
* Build `abi3` .so when building with `maturin develop`
* **Caveat**: after this change, old non-abi3 .so's still lingering in
the rust/perspective-python directory may be loaded preferentially
by Python when using an editable install. It is best to delete
those old .so's.
* Repurpose PyClient as AsyncClient and export bindings to Python
* Add async client pytests for both cpython and pyodide
* Uses `pytest-asyncio` plugin
* Add python and pytest vscode settings
* Supports running cpython pytest suite from vscode's Test Explorer
Signed-off-by: Tom Jakubowski <[email protected]>
tomjakubowski
force-pushed
the
feature/py-async-client
branch
from
4b2fbce to
7974866
Compare
|
I was seeing some new error spew in the pyodide tests and I think there's a bug in pytest-pyodide, filed here pyodide/pytest-pyodide#148 |
tomjakubowski
commented
Feb 21, 2025
| })?; | ||
| if let Some(fut) = Python::with_gil(move |py| -> PyResult<_> { | ||
| let ret = handle_request.call1(py, (PyBytes::new(py, msg),))?; | ||
| if isawaitable(ret.bind(py)).unwrap_or(false) { |
There was a problem hiding this comment.
Crucial change here: if calling the Python callback returns a coroutine (i.e. if the callback is a coroutine function), then convert the coro into a Rust future and then await it (line 72)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
connected client.
PSP_UV=1in environmentuv venvto create venv, then activate ituv pip install -r **/requirements.txtto install requirementspyo3-async-runtimescrateabi3.so when building withmaturin developthe rust/perspective-python directory may be loaded preferentially
by Python when using an editable install. It is best to delete
those old .so's.
pytest-asynciopluginDiscussions, this PR applies to.