Refactor transaction

[tom-andersen]

Moves logic out of SyncEngine.

• Transactions run independently of SyncEngine.
• runAggregateQuery can be run directly on RemoteStore.

[github-actions]

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

[google-oss-bot]

Coverage Report ¹

Affected Products

• firebase-firestore

  Overall coverage changed from 46.05% (8ad9ef5) to 46.05% (f8d6e1f) by +0.00%.

  Filename	Base (8ad9ef5)	Merge (f8d6e1f)	Diff
  SyncEngine.java	89.22%	89.76%	+0.54%

Test Logs

• Base (8ad9ef5): https://github.com/firebase/firebase-android-sdk/actions/runs/10795141564
• Merge (f8d6e1f): https://github.com/firebase/firebase-android-sdk/actions/runs/10814199236

1. https://storage.googleapis.com/firebase-sdk-metric-reports/NRPUUMGDQQ.html

[github-actions]

Unit Test Results

   186 files  +   122     186 suites  +122   4m 43s ⏱️ - 1m 32s
1 234 tests +   747  1 218 ✔️ +   731  16 💤 +16  0 ❌ ±0 
2 492 runs  +1 512  2 460 ✔️ +1 480  32 💤 +32  0 ❌ ±0 

Results for commit 5f0586c. ± Comparison against base commit 8ad9ef5.

This pull request removes 487 and adds 1234 tests. Note that renamed tests count towards both.

com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNoWrappedIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNullIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[21]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[22]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[23]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[24]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_preO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_preO[21]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_preO[22]
…

com.google.firebase.firestore.AggregateQuerySnapshotTest ‑ createWithCountShouldReturnInstanceWithTheGivenQueryAndCount
com.google.firebase.firestore.AggregateQueryTest ‑ testSourceMustNotBeNull
com.google.firebase.firestore.BlobTest ‑ testComparison
com.google.firebase.firestore.BlobTest ‑ testEquals
com.google.firebase.firestore.BlobTest ‑ testMutableBytes
com.google.firebase.firestore.CollectionReferenceTest ‑ testEquals
com.google.firebase.firestore.DocumentChangeTest ‑ randomTests
com.google.firebase.firestore.DocumentChangeTest ‑ testAdditions
com.google.firebase.firestore.DocumentChangeTest ‑ testChangesWithSortOrderChange
com.google.firebase.firestore.DocumentChangeTest ‑ testDeletions
…

♻️ This comment has been updated with latest results.

[google-oss-bot]

Size Report ¹

Affected Products

• firebase-firestore

  Type	Base (8ad9ef5)	Merge (f8d6e1f)	Diff
  aar	1.44 MB	1.44 MB	-335 B (-0.0%)
  apk (release)	11.3 MB	11.3 MB	-200 B (-0.0%)

Test Logs

• Base (8ad9ef5): https://github.com/firebase/firebase-android-sdk/actions/runs/10795141564
• Merge (f8d6e1f): https://github.com/firebase/firebase-android-sdk/actions/runs/10814199236

1. https://storage.googleapis.com/firebase-sdk-metric-reports/yXml4XJ6sY.html

[google-oss-bot]

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

• This report is for comparing the base commit (8ad9ef5) and the CI merge commit (f8d6e1f)
• Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
  • 8ad9ef5: https://storage.googleapis.com/firebase-sdk-metric-reports/baI5dyqyOq/index.html
  • f8d6e1f: https://storage.googleapis.com/firebase-sdk-metric-reports/8kEtWoXdUP/index.html

Startup Times

• fire-fst

  Device	Statistics	Distributions
  oriole-32	Percentile 8ad9ef5 f8d6e1f Diff Significant (?) p10 311 ±21 μs 320 ±20 μs +9.71 μs (+3.1%) NO p25 325 ±29 μs 336 ±24 μs +11.0 μs (+3.4%) NO p50 344 ±43 μs 370 ±45 μs +25.2 μs (+7.3%) NO p75 386 ±78 μs 443 ±97 μs +57.2 μs (+14.8%) NO p90 423 ±99 μs 534 ±104 μs +110 μs (+26.1%) NO 20 test runs in comparison Commit Test Runs 8ad9ef5 2024-09-10_15:09:27.596572_gpCE 2024-09-10_15:09:27.596619_groB 2024-09-10_15:09:27.596631_LbcP 2024-09-10_15:09:27.596639_DqSu 2024-09-10_15:09:27.596648_WMah 2024-09-10_15:09:27.596655_BWNh 2024-09-10_15:09:27.596662_Xrrn 2024-09-10_15:09:27.596675_FDOr 2024-09-10_15:09:27.596683_uRaD 2024-09-10_15:09:27.596690_uLcB f8d6e1f 2024-09-11_15:06:23.985859_suVl 2024-09-11_15:06:23.985907_CrQo 2024-09-11_15:06:23.985917_KEdZ 2024-09-11_15:06:23.985926_akNN 2024-09-11_15:06:23.985935_ebwc 2024-09-11_15:06:23.985943_FoZs 2024-09-11_15:06:23.985950_aBHR 2024-09-11_15:06:23.985957_AeJm 2024-09-11_15:06:23.985965_ieoz 2024-09-11_15:06:23.985981_LSfJ
  redfin-30	Percentile 8ad9ef5 f8d6e1f Diff Significant (?) p10 618 ±35 μs 661 ±172 μs +43.2 μs (+7.0%) NO p25 640 ±44 μs 678 ±178 μs +37.8 μs (+5.9%) NO p50 674 ±54 μs 707 ±181 μs +32.5 μs (+4.8%) NO p75 719 ±64 μs 747 ±193 μs +27.3 μs (+3.8%) NO p90 869 ±234 μs 801 ±206 μs -68.6 μs (-7.9%) NO 20 test runs in comparison Commit Test Runs 8ad9ef5 2024-09-10_15:09:27.596572_gpCE 2024-09-10_15:09:27.596619_groB 2024-09-10_15:09:27.596631_LbcP 2024-09-10_15:09:27.596639_DqSu 2024-09-10_15:09:27.596648_WMah 2024-09-10_15:09:27.596655_BWNh 2024-09-10_15:09:27.596662_Xrrn 2024-09-10_15:09:27.596675_FDOr 2024-09-10_15:09:27.596683_uRaD 2024-09-10_15:09:27.596690_uLcB f8d6e1f 2024-09-11_15:06:23.985859_suVl 2024-09-11_15:06:23.985907_CrQo 2024-09-11_15:06:23.985917_KEdZ 2024-09-11_15:06:23.985926_akNN 2024-09-11_15:06:23.985935_ebwc 2024-09-11_15:06:23.985943_FoZs 2024-09-11_15:06:23.985950_aBHR 2024-09-11_15:06:23.985957_AeJm 2024-09-11_15:06:23.985965_ieoz 2024-09-11_15:06:23.985981_LSfJ

• timeToInitialDisplay

  Device	Statistics	Distributions
  oriole-32	Percentile 8ad9ef5 f8d6e1f Diff Significant (?) p10 202 ±4 ms 205 ±4 ms +3.04 ms (+1.5%) NO p25 208 ±5 ms 211 ±4 ms +3.30 ms (+1.6%) NO p50 216 ±5 ms 219 ±4 ms +2.52 ms (+1.2%) NO p75 224 ±5 ms 229 ±5 ms +4.52 ms (+2.0%) NO p90 231 ±6 ms 242 ±10 ms +11.1 ms (+4.8%) NO 20 test runs in comparison Commit Test Runs 8ad9ef5 2024-09-10_15:09:27.596572_gpCE 2024-09-10_15:09:27.596619_groB 2024-09-10_15:09:27.596631_LbcP 2024-09-10_15:09:27.596639_DqSu 2024-09-10_15:09:27.596648_WMah 2024-09-10_15:09:27.596655_BWNh 2024-09-10_15:09:27.596662_Xrrn 2024-09-10_15:09:27.596675_FDOr 2024-09-10_15:09:27.596683_uRaD 2024-09-10_15:09:27.596690_uLcB f8d6e1f 2024-09-11_15:06:23.985859_suVl 2024-09-11_15:06:23.985907_CrQo 2024-09-11_15:06:23.985917_KEdZ 2024-09-11_15:06:23.985926_akNN 2024-09-11_15:06:23.985935_ebwc 2024-09-11_15:06:23.985943_FoZs 2024-09-11_15:06:23.985950_aBHR 2024-09-11_15:06:23.985957_AeJm 2024-09-11_15:06:23.985965_ieoz 2024-09-11_15:06:23.985981_LSfJ
  redfin-30	Percentile 8ad9ef5 f8d6e1f Diff Significant (?) p10 245 ±4 ms 263 ±7 ms +17.5 ms (+7.1%) NO p25 251 ±4 ms 270 ±8 ms +18.8 ms (+7.5%) NO p50 258 ±5 ms 278 ±7 ms +20.4 ms (+7.9%) MAYBE p75 266 ±5 ms 289 ±8 ms +22.8 ms (+8.6%) MAYBE p90 277 ±8 ms 306 ±9 ms +29.3 ms (+10.6%) MAYBE 20 test runs in comparison Commit Test Runs 8ad9ef5 2024-09-10_15:09:27.596572_gpCE 2024-09-10_15:09:27.596619_groB 2024-09-10_15:09:27.596631_LbcP 2024-09-10_15:09:27.596639_DqSu 2024-09-10_15:09:27.596648_WMah 2024-09-10_15:09:27.596655_BWNh 2024-09-10_15:09:27.596662_Xrrn 2024-09-10_15:09:27.596675_FDOr 2024-09-10_15:09:27.596683_uRaD 2024-09-10_15:09:27.596690_uLcB f8d6e1f 2024-09-11_15:06:23.985859_suVl 2024-09-11_15:06:23.985907_CrQo 2024-09-11_15:06:23.985917_KEdZ 2024-09-11_15:06:23.985926_akNN 2024-09-11_15:06:23.985935_ebwc 2024-09-11_15:06:23.985943_FoZs 2024-09-11_15:06:23.985950_aBHR 2024-09-11_15:06:23.985957_AeJm 2024-09-11_15:06:23.985965_ieoz 2024-09-11_15:06:23.985981_LSfJ

1. https://storage.googleapis.com/firebase-sdk-metric-reports/lrI2AhVEUx/index.html