Skip to content

chore(functions): export reactive-streams as a transitive dependency #6775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2025
Merged

chore(functions): export reactive-streams as a transitive dependency #6775

merged 1 commit into from
Mar 14, 2025

Conversation

thatfiredev
Copy link
Member

Alternative to #6774 - we'll keep that PR for a follow-up release.

For now, we're exposing the reactive-streams dependency to make sure it works out of the box for Java developers.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 14, 2025 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (b9be9f1) and merge commit (9dc00b2).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/keqmnEXua4.html

@github-actions GitHub Actions
Copy link
Contributor

Test Results

14 files  ±0  14 suites  ±0   12s ⏱️ ±0s
23 tests ±0  23 ✅ ±0  0 💤 ±0  0 ❌ ±0 
46 runs  ±0  46 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8bc8896. ± Comparison against base commit b9be9f1.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (b9be9f1) and merge commit (9dc00b2).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/q9Yz1p6sGX.html

@rlazo rlazo merged commit 1aca899 into main Mar 14, 2025
34 of 35 checks passed
@rlazo rlazo deleted the rpf/functions-api-reactive-stream branch March 14, 2025 21:10
tejasd pushed a commit that referenced this pull request Apr 1, 2025
@thatfiredev @tejasd
chore(functions): export reactive-streams as a transitive dependency (#…
06ce410 
…6775)

Alternative to #6774 - we'll keep that PR for a follow-up release.

For now, we're exposing the `reactive-streams` dependency to make sure
it works out of the box for Java developers.
@firebase firebase locked and limited conversation to collaborators Apr 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

@emilypgoogle emilypgoogle Awaiting requested review from emilypgoogle

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thatfiredev @google-oss-bot @rlazo