Skip to content

Update GaugeManager and SessionManager to separate app state changes and PerfSession changes #6876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: fireperf-aqs
Choose a base branch
from

Conversation

tejasd
Copy link
Contributor

@tejasd tejasd commented Apr 15, 2025

No description provided.

Copy link
Contributor

github-actions bot commented Apr 15, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v10.0

@tejasd tejasd changed the base branch from main to fireperf-aqs April 15, 2025 16:07
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

Copy link
Contributor

github-actions bot commented Apr 15, 2025

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 3120db5.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 15, 2025

Coverage Report 1

Affected Products

No changes between base commit (009c1c1) and merge commit (659bf32).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/IvmcrDHPoP.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 15, 2025

Size Report 1

Affected Products

  • base

    TypeBase (8fe1383)Merge (efa78d8)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)
  • firebase-perf

    TypeBase (8fe1383)Merge (efa78d8)Diff
    aar?321 kB? (?)
    apk (aggressive)?1.71 MB? (?)
    apk (release)?10.7 MB? (?)
  • firebase-sessions

    TypeBase (8fe1383)Merge (efa78d8)Diff
    aar?202 kB? (?)
    apk (aggressive)?645 kB? (?)
    apk (release)?6.31 MB? (?)
  • protolite-well-known-types

    TypeBase (8fe1383)Merge (efa78d8)Diff
    aar?1.02 MB? (?)
    apk (aggressive)?134 kB? (?)
    apk (release)?1.71 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/2wSUREELpY.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (acbffec) and the base commit (5aff679) are not available.

No macrobenchmark data found for the base commit (5aff679). Analysis for the CI merge commit (acbffec) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/AKpZVN4Px5/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants