Skip to content

Add process name to application info #6890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

Add process name to application info #6890

merged 1 commit into from
Apr 17, 2025

Conversation

themiswang
Copy link
Contributor

@themiswang themiswang commented Apr 16, 2025 •
edited
Loading

Leverage on ProcessDetailsProvider to retrieve process name info

@themiswang themiswang requested review from tejasd and mrober April 16, 2025 21:01
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 16, 2025 •
edited
Loading

Test Results

  148 files    148 suites   3m 10s ⏱️
1 055 tests 1 055 ✅ 0 💤 0 ❌
2 118 runs  2 118 ✅ 0 💤 0 ❌

Results for commit 4b4dc88.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 16, 2025 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-perf

    Overall coverage changed from ? (8fe1383) to 70.35% (e608cc0) by ?.

    107 individual files with coverage change

    FilenameBase (8fe1383)Merge (e608cc0)Diff
    AddTrace.java?0.00%?
    AndroidApplicationInfo.java?34.71%?
    AndroidApplicationInfoOrBuilder.java?0.00%?
    AndroidLogger.java?100.00%?
    AndroidMemoryReading.java?38.36%?
    AndroidMemoryReadingOrBuilder.java?0.00%?
    ApplicationInfo.java?43.81%?
    ApplicationInfoOrBuilder.java?0.00%?
    ApplicationProcessState.java?73.91%?
    AppStartTrace.java?77.55%?
    AppStateMonitor.java?84.97%?
    AppStateUpdateHandler.java?89.29%?
    Clock.java?100.00%?
    ConfigResolver.java?90.33%?
    ConfigurationConstants.java?97.93%?
    ConfigurationFlag.java?80.00%?
    ConsoleUrlGenerator.java?37.50%?
    Constants.java?95.65%?
    Counter.java?90.91%?
    CpuGaugeCollector.java?93.83%?
    CpuMetricReading.java?39.33%?
    CpuMetricReadingOrBuilder.java?0.00%?
    DaggerFirebasePerformanceComponent.java?100.00%?
    DeviceCacheManager.java?76.42%?
    FirebasePerfApplicationInfoValidator.java?92.86%?
    FirebasePerfEarly.java?76.92%?
    FirebasePerfGaugeMetricValidator.java?100.00%?
    FirebasePerfHttpClient.java?93.85%?
    FirebasePerfMetricProto.java?0.00%?
    FirebasePerfNetworkValidator.java?86.67%?
    FirebasePerfOkHttpClient.java?44.90%?
    FirebasePerformance.java?77.17%?
    FirebasePerformanceAttributable.java?0.00%?
    FirebasePerformanceComponent.java?0.00%?
    FirebasePerformanceInitializer.java?28.57%?
    FirebasePerformanceModule.java?100.00%?
    FirebasePerformanceModule_ProvidesConfigResolverFactory.java?0.00%?
    FirebasePerformanceModule_ProvidesFirebaseAppFactory.java?0.00%?
    FirebasePerformanceModule_ProvidesFirebaseInstallationsFactory.java?0.00%?
    FirebasePerformanceModule_ProvidesRemoteConfigComponentFactory.java?0.00%?
    FirebasePerformanceModule_ProvidesRemoteConfigManagerFactory.java?0.00%?
    FirebasePerformanceModule_ProvidesSessionManagerFactory.java?0.00%?
    FirebasePerformanceModule_ProvidesTransportFactoryProviderFactory.java?0.00%?
    FirebasePerformanceSessionSubscriber.kt?22.22%?
    FirebasePerformance_Factory.java?0.00%?
    FirebasePerfRegistrar.java?100.00%?
    FirebasePerfTraceValidator.java?85.87%?
    FirebasePerfUrlConnection.java?44.44%?
    FirebaseSessionsEnforcementCheck.kt?85.71%?
    FirebaseSessionsHelper.kt?100.00%?
    FirstDrawDoneListener.java?85.71%?
    FlgTransport.java?83.33%?
    FragmentStateMonitor.java?94.87%?
    FrameMetricsCalculator.java?96.77%?
    FrameMetricsRecorder.java?76.32%?
    GaugeManager.java?98.37%?
    GaugeMetadata.java?26.17%?
    GaugeMetadataManager.java?100.00%?
    GaugeMetadataOrBuilder.java?0.00%?
    GaugeMetric.java?39.47%?
    GaugeMetricOrBuilder.java?0.00%?
    HttpMetric.java?92.65%?
    ImmutableBundle.java?100.00%?
    InstrHttpInputStream.java?92.45%?
    InstrHttpOutputStream.java?98.00%?
    InstrHttpsURLConnection.java?94.32%?
    InstrHttpURLConnection.java?93.42%?
    InstrumentApacheHttpResponseHandler.java?100.00%?
    InstrumentOkHttpEnqueueCallback.java?100.00%?
    InstrURLConnectionBase.java?94.86%?
    LogWrapper.java?23.08%?
    MemoryGaugeCollector.java?89.66%?
    NetworkConnectionInfo.java?0.00%?
    NetworkConnectionInfoOrBuilder.java?0.00%?
    NetworkRequestMetric.java?49.16%?
    NetworkRequestMetricBuilder.java?95.97%?
    NetworkRequestMetricBuilderUtil.java?75.00%?
    NetworkRequestMetricOrBuilder.java?0.00%?
    Optional.java?86.67%?
    PendingPerfEvent.java?100.00%?
    PerfMetric.java?33.67%?
    PerfMetricOrBuilder.java?0.00%?
    PerfMetricValidator.java?93.55%?
    Performance.kt?7.14%?
    PerfSession.java?93.55%?
    PerfSessionOrBuilder.java?0.00%?
    PreDrawListener.java?94.12%?
    Rate.java?100.00%?
    RateLimiter.java?90.77%?
    RemoteConfigManager.java?90.28%?
    ResourceType.java?0.00%?
    ScreenTraceUtil.java?94.12%?
    SessionAwareObject.java?0.00%?
    SessionManager.java?100.00%?
    SessionVerbosity.java?68.42%?
    StorageUnit.java?57.89%?
    Timer.java?90.63%?
    Trace.java?95.83%?
    TraceMetric.java?43.14%?
    TraceMetricBuilder.java?100.00%?
    TraceMetricOrBuilder.java?0.00%?
    TransportInfo.java?0.00%?
    TransportInfoOrBuilder.java?0.00%?
    TransportManager.java?94.93%?
    URLAllowlist.java?94.44%?
    URLWrapper.java?0.00%?
    Utils.java?78.57%?

  • firebase-sessions

    Overall coverage changed from ? (8fe1383) to 66.70% (e608cc0) by ?.

    48 individual files with coverage change

    FilenameBase (8fe1383)Merge (e608cc0)Diff
    ApplicationInfo.kt?100.00%?
    AutoSessionEventEncoder.java?100.00%?
    Comparisons.kt?100.00%?
    DaggerFirebaseSessionsComponent.java?0.00%?
    Emitters.kt?0.00%?
    EventGDTLogger.kt?70.00%?
    EventGDTLogger_Factory.java?0.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsComponent.kt?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_ApplicationInfoFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_SessionConfigsDataStoreFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_SessionDetailsDataStoreFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_TimeProviderFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_UuidGeneratorFactory.java?0.00%?
    FirebaseSessionsDependencies.kt?92.00%?
    FirebaseSessionsRegistrar.kt?0.00%?
    FirebaseSessions_Factory.java?0.00%?
    InstallationId.kt?100.00%?
    LocalOverrideSettings.kt?100.00%?
    LocalOverrideSettings_Factory.java?0.00%?
    ProcessDetailsProvider.kt?74.19%?
    RemoteSettings.kt?88.73%?
    RemoteSettingsFetcher.kt?0.00%?
    RemoteSettingsFetcher_Factory.java?0.00%?
    RemoteSettings_Factory.java?0.00%?
    SafeCollector.common.kt?0.00%?
    SessionDatastore.kt?3.33%?
    SessionDataStoreConfigs.kt?100.00%?
    SessionDatastoreImpl_Factory.java?0.00%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?98.00%?
    SessionFirelogPublisher.kt?84.21%?
    SessionFirelogPublisherImpl_Factory.java?0.00%?
    SessionGenerator.kt?90.91%?
    SessionGenerator_Factory.java?0.00%?
    SessionLifecycleClient.kt?91.78%?
    SessionLifecycleService.kt?78.65%?
    SessionLifecycleServiceBinder.kt?0.00%?
    SessionLifecycleServiceBinderImpl_Factory.java?0.00%?
    SessionsActivityLifecycleCallbacks.kt?55.56%?
    SessionsSettings.kt?96.88%?
    SessionsSettings_Factory.java?0.00%?
    SessionSubscriber.kt?100.00%?
    SettingsCache.kt?93.55%?
    SettingsCache_Factory.java?0.00%?
    SettingsProvider.kt?50.00%?
    TimeProvider.kt?0.00%?
    UuidGenerator.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/CVMjED2sdF.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 16, 2025 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (8fe1383)Merge (e608cc0)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)

  • firebase-perf

    TypeBase (8fe1383)Merge (e608cc0)Diff
    aar?321 kB? (?)
    apk (aggressive)?1.71 MB? (?)
    apk (release)?10.7 MB? (?)

  • firebase-sessions

    TypeBase (8fe1383)Merge (e608cc0)Diff
    aar?203 kB? (?)
    apk (aggressive)?645 kB? (?)
    apk (release)?6.31 MB? (?)

  • protolite-well-known-types

    TypeBase (8fe1383)Merge (e608cc0)Diff
    aar?1.02 MB? (?)
    apk (aggressive)?134 kB? (?)
    apk (release)?1.71 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XBAIEwFkPb.html

raymondlam
raymondlam reviewed Apr 16, 2025
View reviewed changes
Copy link
Member

@raymondlam raymondlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the tests (validateApplicationInfo) in TransportManagerTest?

I suspect that you might need to pass ProcessDetailsProvider in the initialize() call for it to be mockable in the test

@themiswang themiswang requested a review from raymondlam April 17, 2025 15:27
@themiswang themiswang merged commit 009c1c1 into fireperf-aqs Apr 17, 2025
36 of 38 checks passed
@themiswang themiswang deleted the processName branch April 17, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raymondlam raymondlam raymondlam approved these changes

@mrober mrober mrober approved these changes

@tejasd tejasd Awaiting requested review from tejasd

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@themiswang @google-oss-bot @raymondlam @mrober