Skip to content

[Crashlytics] Sync signal/exception handler installation #15576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
paulb777 wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −10
Draft

[Crashlytics] Sync signal/exception handler installation #15576

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6ea16c
[Crashlytics] Sync signal/exception handler installation
paulb777 Dec 5, 2025
9523362
remove blank line
paulb777 Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Crashlytics/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# Unreleased
- [fixed] Installed Crashlytics signal and mach exception handlers synchronously to
improve compatibility with other crash reporters and runtime environments (like
Mono/Xamarin). (#15383)

# 12.4.0
- [fixed] Make set development platform APIs to chain on Crashlytics context init promise.

Expand Down
17 changes: 7 additions & 10 deletions Crashlytics/Crashlytics/Components/FIRCLSContext.m
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@

// Copyright 2019 Google
//
// Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -172,21 +173,17 @@
// simulator to crash.
if (!_firclsContext.readonly->debuggerAttached) {
#if CLS_SIGNAL_SUPPORTED
dispatch_group_async(group, queue, ^{
_firclsContext.readonly->signal.path =
FIRCLSContextAppendToRoot(rootPath, FIRCLSReportSignalFile);
_firclsContext.readonly->signal.path =
FIRCLSContextAppendToRoot(rootPath, FIRCLSReportSignalFile);

FIRCLSSignalInitialize(&_firclsContext.readonly->signal);
});
FIRCLSSignalInitialize(&_firclsContext.readonly->signal);
#endif

#if CLS_MACH_EXCEPTION_SUPPORTED
dispatch_group_async(group, queue, ^{
_firclsContext.readonly->machException.path =
FIRCLSContextAppendToRoot(rootPath, FIRCLSReportMachExceptionFile);
_firclsContext.readonly->machException.path =
FIRCLSContextAppendToRoot(rootPath, FIRCLSReportMachExceptionFile);

FIRCLSMachExceptionInit(&_firclsContext.readonly->machException);
});
FIRCLSMachExceptionInit(&_firclsContext.readonly->machException);
#endif

dispatch_group_async(group, queue, ^{
Expand Down
Loading