Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ServerApp] Remove appCheck and installations tokens. Will ad them back later #7989

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Jan 29, 2024

This is a PR against a feature branch, not against master.

Discussion

Removed the appCheck and installations token parameters in FirebaseServerAppSettings as they won't be part of our initial launch. Additionally, update the the doxgen comments to no longer refer to these parameters, and to inform users that the User refreshToken will not work for User objects signed in with the authIdToken.

Testing

CI.

API Changes

N/A. Feature branch changes.

Copy link

changeset-bot bot commented Jan 29, 2024

⚠️ No Changeset found

Latest commit: 22d18f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 29, 2024

Size Report 1

Affected Products

  • @firebase/app

    TypeBase (fc44b08)Merge (8abcb60)Diff
    browser18.0 kB17.8 kB-224 B (-1.2%)
    esm523.4 kB23.2 kB-224 B (-1.0%)
    main24.5 kB24.2 kB-224 B (-0.9%)
    module18.0 kB17.8 kB-224 B (-1.2%)
  • firebase

    TypeBase (fc44b08)Merge (8abcb60)Diff
    firebase-app-compat.js31.4 kB31.2 kB-108 B (-0.3%)
    firebase-app.js101 kB100 kB-248 B (-0.2%)
    firebase-compat.js782 kB782 kB-108 B (-0.0%)
    firebase-performance-standalone-compat.es2017.js93.2 kB93.1 kB-108 B (-0.1%)
    firebase-performance-standalone-compat.js70.2 kB70.1 kB-108 B (-0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/BySgn1KW4X.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 29, 2024

Size Analysis Report 1

Affected Products

  • @firebase/app

    • initializeServerApp

      Size

      TypeBase (fc44b08)Merge (8abcb60)Diff
      size11.2 kB11.1 kB-134 B (-1.2%)
      size-with-ext-deps25.0 kB24.9 kB-134 B (-0.5%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/bXdADCvivu.html

@DellaBitta DellaBitta marked this pull request as ready for review January 29, 2024 20:13
@DellaBitta DellaBitta merged commit 562d619 into feature-firebaseserverapp Jan 29, 2024
40 of 41 checks passed
@DellaBitta DellaBitta deleted the ddb-token-refresh-guidance branch January 29, 2024 20:14
@firebase firebase locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants