Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HarmSeverity.HARM_SEVERITY_UNSPECIFIED #8830

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add HarmSeverity.HARM_SEVERITY_UNSPECIFIED #8830

wants to merge 2 commits into from

Conversation

dlarocque
Copy link
Contributor

@dlarocque dlarocque commented Mar 5, 2025 •
edited
Loading

Add HarmSeverity.HARM_SEVERITY_UNSPECIFIED. Will serve as a fallback for when HarmSeverity is undefined in the future.

This is a part of the proto.

@dlarocque dlarocque requested review from a team as code owners March 5, 2025 16:16
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 59681b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@firebase/vertexai Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dlarocque dlarocque changed the title Add HarmSeverity.HARM_SEVERITY_UNSPECIFED Add HarmSeverity.HARM_SEVERITY_UNSPECIFIED Mar 5, 2025
@dlarocque dlarocque requested review from a team as code owners March 5, 2025 16:17
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 5, 2025 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/vertexai

    TypeBase (42cea48)Merge (ffe36f5)Diff
    browser34.2 kB34.3 kB+70 B (+0.2%)
    main35.2 kB35.3 kB+70 B (+0.2%)
    module34.2 kB34.3 kB+70 B (+0.2%)

  • firebase

    TypeBase (42cea48)Merge (ffe36f5)Diff
    firebase-vertexai.js27.8 kB27.9 kB+56 B (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6X6F6Z035n.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 5, 2025 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/vertexai

    • ArraySchema

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size5.50 kB5.56 kB+59 B (+1.1%)
      size-with-ext-deps23.4 kB23.5 kB+59 B (+0.3%)

    • BlockReason

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size3.41 kB3.47 kB+59 B (+1.7%)
      size-with-ext-deps21.3 kB21.4 kB+59 B (+0.3%)

    • BooleanSchema

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size5.50 kB5.56 kB+59 B (+1.1%)
      size-with-ext-deps23.4 kB23.5 kB+59 B (+0.3%)

    • ChatSession

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size15.7 kB15.8 kB+59 B (+0.4%)
      size-with-ext-deps34.6 kB34.7 kB+59 B (+0.2%)

    • FinishReason

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size3.41 kB3.47 kB+59 B (+1.7%)
      size-with-ext-deps21.3 kB21.4 kB+59 B (+0.3%)

    • FunctionCallingMode

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size3.42 kB3.48 kB+59 B (+1.7%)
      size-with-ext-deps21.3 kB21.4 kB+59 B (+0.3%)

    • GenerativeModel

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size18.5 kB18.5 kB+59 B (+0.3%)
      size-with-ext-deps37.4 kB37.5 kB+59 B (+0.2%)

    • HarmBlockMethod

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size3.41 kB3.47 kB+59 B (+1.7%)
      size-with-ext-deps21.3 kB21.4 kB+59 B (+0.3%)

    • HarmBlockThreshold

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size3.42 kB3.48 kB+59 B (+1.7%)
      size-with-ext-deps21.3 kB21.4 kB+59 B (+0.3%)

    • HarmCategory

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size3.41 kB3.47 kB+59 B (+1.7%)
      size-with-ext-deps21.3 kB21.4 kB+59 B (+0.3%)

    • HarmProbability

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size3.41 kB3.47 kB+59 B (+1.7%)
      size-with-ext-deps21.3 kB21.4 kB+59 B (+0.3%)

    • HarmSeverity

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size3.41 kB3.47 kB+59 B (+1.7%)
      size-with-ext-deps21.3 kB21.4 kB+59 B (+0.3%)

    • ImagenAspectRatio

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size3.42 kB3.47 kB+59 B (+1.7%)
      size-with-ext-deps21.3 kB21.4 kB+59 B (+0.3%)

    • ImagenImageFormat

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size3.70 kB3.75 kB+59 B (+1.6%)
      size-with-ext-deps21.6 kB21.7 kB+59 B (+0.3%)

    • ImagenModel

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size9.63 kB9.69 kB+59 B (+0.6%)
      size-with-ext-deps27.6 kB27.7 kB+59 B (+0.2%)

    • ImagenPersonFilterLevel

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size3.42 kB3.48 kB+59 B (+1.7%)
      size-with-ext-deps21.3 kB21.4 kB+59 B (+0.3%)

    • ImagenSafetyFilterLevel

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size3.42 kB3.48 kB+59 B (+1.7%)
      size-with-ext-deps21.3 kB21.4 kB+59 B (+0.3%)

    • IntegerSchema

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size5.50 kB5.56 kB+59 B (+1.1%)
      size-with-ext-deps23.4 kB23.5 kB+59 B (+0.3%)

    • Modality

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size3.41 kB3.47 kB+59 B (+1.7%)
      size-with-ext-deps21.3 kB21.4 kB+59 B (+0.3%)

    • NumberSchema

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size5.50 kB5.56 kB+59 B (+1.1%)
      size-with-ext-deps23.4 kB23.5 kB+59 B (+0.3%)

    • ObjectSchema

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size5.50 kB5.56 kB+59 B (+1.1%)
      size-with-ext-deps23.4 kB23.5 kB+59 B (+0.3%)

    • POSSIBLE_ROLES

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size3.46 kB3.52 kB+59 B (+1.7%)
      size-with-ext-deps21.4 kB21.4 kB+59 B (+0.3%)

    • Schema

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size5.49 kB5.55 kB+59 B (+1.1%)
      size-with-ext-deps23.4 kB23.5 kB+59 B (+0.3%)

    • SchemaType

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size3.41 kB3.47 kB+59 B (+1.7%)
      size-with-ext-deps21.3 kB21.4 kB+59 B (+0.3%)

    • StringSchema

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size5.50 kB5.56 kB+59 B (+1.1%)
      size-with-ext-deps23.4 kB23.5 kB+59 B (+0.3%)

    • VertexAIError

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size3.72 kB3.78 kB+59 B (+1.6%)
      size-with-ext-deps21.6 kB21.7 kB+59 B (+0.3%)

    • VertexAIModel

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size4.89 kB4.95 kB+59 B (+1.2%)
      size-with-ext-deps22.8 kB22.9 kB+59 B (+0.3%)

    • getGenerativeModel

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size18.6 kB18.7 kB+59 B (+0.3%)
      size-with-ext-deps37.6 kB37.7 kB+59 B (+0.2%)

    • getImagenModel

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size9.79 kB9.85 kB+59 B (+0.6%)
      size-with-ext-deps27.8 kB27.8 kB+59 B (+0.2%)

    • getVertexAI

      Size

      TypeBase (42cea48)Merge (ffe36f5)Diff
      size3.59 kB3.65 kB+59 B (+1.6%)
      size-with-ext-deps28.8 kB28.9 kB+59 B (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/wMNfLxvJq2.html

hsubox76
hsubox76 reviewed Mar 5, 2025
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So for context, we removed all the UNSPECIFIEDs in #8514 and you can look at the linked gDoc in that PR to see where that was decided - was that incorrect? Should we put them all back? Or only this one?

@dlarocque
Copy link
Contributor Author

So for context, we removed all the UNSPECIFIEDs in #8514 and you can look at the linked gDoc in that PR to see where that was decided - was that incorrect? Should we put them all back? Or only this one?

I didn't know this, thanks for bringing it up- I'll hold off on adding this for now and get back to you on whether we actually want to bring these enum values back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsubox76 hsubox76 hsubox76 left review comments

@rachelsaunders rachelsaunders rachelsaunders approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dlarocque @google-oss-bot @hsubox76 @rachelsaunders