-
Notifications
You must be signed in to change notification settings - Fork 4k
feat(firebase_messaging, Apple): Adds the action identifier #17324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(firebase_messaging, Apple): Adds the action identifier #17324
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hey there 👋 , can you please sign the CLA? |
@Hackmodford - Considering this is Apple specific, I think it should be on this: https://github.com/Hackmodford/flutterfire/blob/feat(firebase_messaging)--Add-ios-action-identifier/packages/firebase_messaging/firebase_messaging_platform_interface/lib/src/remote_notification.dart#L69 You can update it on the notificationDict by accessing |
@russellwheatley I considered that, but noticed the category (which is Apple specific) is not there. So I put it next to that for consistency. @MichaelVerdon I'm in the process of getting authorization from my company to sign the CLA. |
CLA has been signed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hackmodford - that's a fair point regarding leaving it on RemoteMessage, I'm happy to keep it there.
NSMutableDictionary *notificationDict = | ||
[[FLTFirebaseMessagingPlugin remoteMessageUserInfoToDict:remoteNotification] mutableCopy]; | ||
if (response.actionIdentifier != nil) { | ||
notificationDict[@"actionIdentifier"] = response.actionIdentifier; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave a note that this is a property on RemoteMessage like:
// message.actionIdentifier
Description
Adds the action identifier to the RemoteMessage object
Related Issues
closes #17315
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?