Skip to content

feat(py): Added ModelGarden plugin #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zarinn3pal
Copy link
Contributor

Description here... Help the reviewer by:

  • Added Model garden to vertexAI and implemented openai_compatibility support

Checklist (if applicable):

@github-actions github-actions bot added docs Improvements or additions to documentation feature New feature or request python Python config labels Mar 31, 2025
@zarinn3pal zarinn3pal force-pushed the zarinn3pal/feat/add-model-garden branch from cc8ad8e to 4131b28 Compare April 16, 2025 13:59
@zarinn3pal zarinn3pal marked this pull request as ready for review April 16, 2025 14:00
@zarinn3pal zarinn3pal requested a review from pavelgj as a code owner April 16, 2025 14:00
@zarinn3pal zarinn3pal force-pushed the zarinn3pal/feat/add-model-garden branch from 4131b28 to 91ca7ae Compare April 16, 2025 14:46
@zarinn3pal
Copy link
Contributor Author

Hi @pavelgj , @timere-nemo @yesudeep ,

Can you please help review this?

Thank you.

@zarinn3pal zarinn3pal force-pushed the zarinn3pal/feat/add-model-garden branch from 91ca7ae to 89315ba Compare April 16, 2025 15:15
@zarinn3pal zarinn3pal force-pushed the zarinn3pal/feat/add-model-garden branch from 89315ba to 25028b1 Compare April 16, 2025 16:17
@zarinn3pal zarinn3pal requested a review from yesudeep April 16, 2025 16:20
@zarinn3pal zarinn3pal force-pushed the zarinn3pal/feat/add-model-garden branch from 25028b1 to 4e9eadc Compare April 16, 2025 16:57
@zarinn3pal zarinn3pal force-pushed the zarinn3pal/feat/add-model-garden branch from 4e9eadc to 0b1d198 Compare April 23, 2025 10:41
@zarinn3pal zarinn3pal requested a review from pavelgj April 23, 2025 10:42
@@ -246,7 +246,7 @@ export const DatasetMetadataSchema = z.object({
schema: DatasetSchemaSchema.optional(),
datasetType: DatasetTypeSchema,
targetAction: z.string().optional(),
metricRefs: z.array(z.string()),
metricRefs: z.array(z.string()).default([]),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these changes intentional?

@github-actions github-actions bot added the root label Apr 29, 2025
@hendrixmar hendrixmar force-pushed the zarinn3pal/feat/add-model-garden branch from bf791e8 to 0b1d198 Compare April 29, 2025 13:20
@zarinn3pal zarinn3pal force-pushed the zarinn3pal/feat/add-model-garden branch from 0b1d198 to 25f9f02 Compare April 30, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config docs Improvements or additions to documentation feature New feature or request go js python Python root tooling
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants