-
Notifications
You must be signed in to change notification settings - Fork 242
feat(py): Added ModelGarden plugin #2568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zarinn3pal
wants to merge
1
commit into
main
Choose a base branch
from
zarinn3pal/feat/add-model-garden
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
yesudeep
requested changes
Apr 1, 2025
py/plugins/vertex-ai/src/genkit/plugins/vertex_ai/model_garden/openai_compatibility.py
Outdated
Show resolved
Hide resolved
yesudeep
requested changes
Apr 7, 2025
py/plugins/vertex-ai/src/genkit/plugins/vertex_ai/model_garden/modelgarden_plugin.py
Outdated
Show resolved
Hide resolved
py/plugins/vertex-ai/src/genkit/plugins/vertex_ai/model_garden/modelgarden_plugin.py
Show resolved
Hide resolved
py/plugins/vertex-ai/src/genkit/plugins/vertex_ai/model_garden/openai_compatibility.py
Outdated
Show resolved
Hide resolved
yesudeep
requested changes
Apr 8, 2025
py/plugins/vertex-ai/src/genkit/plugins/vertex_ai/model_garden/model_garden.py
Outdated
Show resolved
Hide resolved
py/plugins/vertex-ai/src/genkit/plugins/vertex_ai/model_garden/modelgarden_plugin.py
Outdated
Show resolved
Hide resolved
py/plugins/vertex-ai/src/genkit/plugins/vertex_ai/model_garden/openai_compatibility.py
Outdated
Show resolved
Hide resolved
py/plugins/vertex-ai/src/genkit/plugins/vertex_ai/model_garden/openai_compatibility.py
Outdated
Show resolved
Hide resolved
4 tasks
cc8ad8e
to
4131b28
Compare
4131b28
to
91ca7ae
Compare
Hi @pavelgj , @timere-nemo @yesudeep , Can you please help review this? Thank you. |
91ca7ae
to
89315ba
Compare
yesudeep
requested changes
Apr 16, 2025
py/plugins/vertex-ai/src/genkit/plugins/vertex_ai/model_garden/model_garden.py
Show resolved
Hide resolved
89315ba
to
25028b1
Compare
yesudeep
reviewed
Apr 16, 2025
25028b1
to
4e9eadc
Compare
pavelgj
reviewed
Apr 19, 2025
py/plugins/vertex-ai/src/genkit/plugins/vertex_ai/model_garden/modelgarden_plugin.py
Outdated
Show resolved
Hide resolved
pavelgj
reviewed
Apr 19, 2025
py/plugins/vertex-ai/src/genkit/plugins/vertex_ai/model_garden/model_garden.py
Outdated
Show resolved
Hide resolved
pavelgj
reviewed
Apr 19, 2025
py/plugins/vertex-ai/src/genkit/plugins/vertex_ai/model_garden/model_garden.py
Outdated
Show resolved
Hide resolved
pavelgj
reviewed
Apr 19, 2025
py/plugins/vertex-ai/src/genkit/plugins/vertex_ai/model_garden/model_garden.py
Outdated
Show resolved
Hide resolved
4e9eadc
to
0b1d198
Compare
pavelgj
reviewed
Apr 23, 2025
py/plugins/compat-oai/src/genkit/plugins/compat_oai/models/model_info.py
Show resolved
Hide resolved
pavelgj
reviewed
Apr 23, 2025
py/plugins/compat-oai/src/genkit/plugins/compat_oai/models/handler.py
Outdated
Show resolved
Hide resolved
pavelgj
reviewed
Apr 23, 2025
yesudeep
requested changes
Apr 28, 2025
py/plugins/compat-oai/src/genkit/plugins/compat_oai/models/model_info.py
Outdated
Show resolved
Hide resolved
@@ -246,7 +246,7 @@ export const DatasetMetadataSchema = z.object({ | |||
schema: DatasetSchemaSchema.optional(), | |||
datasetType: DatasetTypeSchema, | |||
targetAction: z.string().optional(), | |||
metricRefs: z.array(z.string()), | |||
metricRefs: z.array(z.string()).default([]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these changes intentional?
bf791e8
to
0b1d198
Compare
0b1d198
to
25f9f02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description here... Help the reviewer by:
Checklist (if applicable):