Skip to content

Conversation

@ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Oct 28, 2025

Follow-up work

  • Migrate away from Ruby Xcodeproj (make an issue pot.)

@gemini-code-assist
Copy link

Summary of Changes

Hello @ncooke3, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on standardizing the naming within the PerformanceExample Xcode project by removing the 'Swift' suffix from the primary application and UI test targets. This change streamlines the project's internal naming conventions, making them more generic, and is complemented by the introduction of new Xcode schemes to ensure the project remains fully functional and testable under the updated names.

Highlights

  • Project Renaming: The main application target and UI test target names within the Xcode project have been updated, removing the 'Swift' suffix. Specifically, 'PerformanceExampleSwift' is now 'PerformanceExample', and 'PerformanceExampleSwiftUITests' is now 'PerformanceExampleUITests'.
  • Xcode Project File Updates: Numerous internal references within the project.pbxproj file were modified to reflect the new naming convention for targets, products, and build configurations, ensuring consistency across the project.
  • New Xcode Schemes: Two new Xcode schemes, PerformanceExample.xcscheme and PerformanceExampleUITests.xcscheme, were added. These schemes are essential for properly building, running, and testing the renamed application and UI test targets.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/performance.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to remove the Swift suffix from the performance example project. The changes correctly update many references in the Xcode project file and add new schemes with the updated names. However, I've noticed a couple of productName properties that were missed. I've left suggestions to update them for consistency. Additionally, for better long-term maintainability, you might consider also renaming the source directories and files (e.g., PerformanceExampleSwift, PerformanceExampleSwiftUITests.swift) to match the new target names. This could be done in a follow-up PR if it's out of scope for this one.

Comment on lines +136 to +138
name = PerformanceExampleUITests;
productName = PerformanceExampleSwiftUITests;
productReference = 107347C420315A61004A66D1 /* PerformanceExampleSwiftUITests.xctest */;
productReference = 107347C420315A61004A66D1 /* PerformanceExampleUITests.xctest */;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The productName still includes the Swift suffix. To be consistent with the goal of this PR, it should be removed.

            name = PerformanceExampleUITests;
            productName = PerformanceExampleUITests;
            productReference = 107347C420315A61004A66D1 /* PerformanceExampleUITests.xctest */;

Comment on lines +153 to +155
name = PerformanceExample;
productName = PerformanceExampleSwift;
productReference = 5F5A53791ADE67D500F81DF0 /* PerformanceExampleSwift.app */;
productReference = 5F5A53791ADE67D500F81DF0 /* PerformanceExample.app */;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The productName still includes the Swift suffix. It should be removed to align with the other renames in this file.

            name = PerformanceExample;
            productName = PerformanceExample;
            productReference = 5F5A53791ADE67D500F81DF0 /* PerformanceExample.app */;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant