-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Update README.md #927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update README.md #927
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @zwgsyko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refining the project's Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the main README.md file by removing references to a few authentication samples. While the changes to the README.md file itself are minor, they introduce inconsistencies with other parts of the project. Specifically, the samples for Facebook popup/redirect authentication and Multi-Factor Authentication are removed from the main list, but the corresponding sample files and their mentions in auth/README.md are still present. This could lead to confusion for users trying to navigate the samples. My review includes suggestions to address these inconsistencies.
I am having trouble creating individual review comments. Click here to see my feedback.
README.md (16-17)
These two list items for Facebook authentication via popup and redirect are being removed. However, the sample files (auth/facebook-popup.html, auth/facebook-redirect.html) and the references in auth/README.md (line 10) still exist. This could be confusing for users. If these samples are being deprecated, consider removing the corresponding files and updating auth/README.md as well. If not, these items should likely be kept in the list.
README.md (27)
This list item for Multi-factor authentication is being removed. However, the sample for MFA (auth/mfa-password.html) and its documentation in auth/README.md (line 14) still exist. This creates an inconsistency. If the sample is still supported, it should be listed here. Note that the original item was also missing a link to the sample file, unlike other items in the list. If the sample is being removed, the corresponding files should also be deleted to avoid confusion.
No description provided.