chore(vmclock): Propagate VMClock restoration error#5681
Merged
zulinx86 merged 3 commits intoFeb 16, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5681 +/- ##
=======================================
Coverage 83.12% 83.12%
=======================================
Files 277 277
Lines 29380 29376 -4
=======================================
- Hits 24423 24420 -3
+ Misses 4957 4956 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zulinx86
force-pushed
the
snapshot_fuzz_for_vmclock
branch
2 times, most recently
from
dc21b91 to
262fc72
Compare
zulinx86
added
the
Status: Awaiting review
ilstam
reviewed
Feb 12, 2026
ilstam
reviewed
Feb 12, 2026
zulinx86
force-pushed
the
snapshot_fuzz_for_vmclock
branch
2 times, most recently
from
75d0ed2 to
d6c4637
Compare
zulinx86
changed the title
zulinx86
force-pushed
the
snapshot_fuzz_for_vmclock
branch
from
d6c4637 to
483b5a2
Compare
JackThomson2
previously approved these changes
Feb 12, 2026
Manciukic
reviewed
Feb 16, 2026
zulinx86
force-pushed
the
snapshot_fuzz_for_vmclock
branch
2 times, most recently
from
409b802 to
1c84c12
Compare
The fuzzer somtimes provides a too large guest address for VMClock ABI structure as it fuzzes the snapshot data. That makes unchecked_add() panic when adding field offsets. To avoid the panic, call attach_vmclock() on snapshot restore that internally calls mem.write_slice() and returns an error for out-of-range access and propagate the error up the stack. Note that Firecracker never allocates such a too large guest address. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
VmClock::restore() does NOT mutate it at all. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
zulinx86
force-pushed
the
snapshot_fuzz_for_vmclock
branch
from
1c84c12 to
4503d0c
Compare
ShadowCurse
approved these changes
Feb 16, 2026
Manciukic
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes / Reason
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.