Matfree adjoint interpolation#4552
Merged
Merged
Conversation
pbrubeck
force-pushed
the
pbrubeck/interp-adjoint
branch
4 times, most recently
from
ad949f7 to
515b7f9
Compare
pbrubeck
force-pushed
the
pbrubeck/interp-adjoint
branch
7 times, most recently
from
95d17dc to
4ba0933
Compare
pbrubeck
force-pushed
the
pbrubeck/interp-adjoint
branch
2 times, most recently
from
94c1000 to
d8120e5
Compare
pbrubeck
force-pushed
the
pbrubeck/interp-adjoint
branch
from
d8120e5 to
a33cfb3
Compare
pbrubeck
force-pushed
the
pbrubeck/interp-adjoint
branch
from
5113864 to
d51db25
Compare
pbrubeck
force-pushed
the
pbrubeck/interp-adjoint
branch
from
98ca954 to
afe0256
Compare
pbrubeck
force-pushed
the
pbrubeck/interp-adjoint
branch
4 times, most recently
from
2fbbddf to
27acd62
Compare
pbrubeck
force-pushed
the
pbrubeck/interp-adjoint
branch
from
27acd62 to
4ce9f8e
Compare
pbrubeck
force-pushed
the
pbrubeck/interp-adjoint
branch
from
5d800f9 to
120a2a3
Compare
leo-collins
reviewed
Sep 19, 2025
connorjward
requested changes
Sep 26, 2025
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
Looks mostly fine I think. Need someone else to review the maths.
Contributor
Author
The adjoint tests should speak for themselves. I'm pretty sure @dham would agree with this statement. |
Co-authored-by: Connor Ward <c.ward20@imperial.ac.uk>
pbrubeck
commented
Sep 26, 2025
pbrubeck
commented
Sep 26, 2025
dham
reviewed
Sep 26, 2025
pbrubeck
commented
Sep 26, 2025
dham
reviewed
Sep 30, 2025
Co-authored-by: David A. Ham <david.ham@imperial.ac.uk>
connorjward
previously approved these changes
Sep 30, 2025
pbrubeck
commented
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements automatic code generation for the matrix-free assembly of dual interpolation (which previously was computed as a matvec with an explicit matrix).
This PR applies to the adjoint where the meshes are the same one. In #4576 this code generation is extended to interpolation from a standard mesh into a
SubmeshandVertexOnlyMesh.CrossMeshInterpolatorandVomOntoVomXXXare deferred as future work #4592.