Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/182 #244

Closed
wants to merge 13 commits into from
Closed

Feature/182 #244

wants to merge 13 commits into from

Conversation

Schrank
Copy link
Member

@Schrank Schrank commented May 29, 2015

Implements #182

@sprankhub
Copy link
Member

Cool, thanks!

  1. Could you please merge the dev branch?
  2. Wouldn't it be nicer to simply add two actions to the admin menu like "Download as one PDF" and "Download as ZIP" instead of having another configuration option?

@Schrank
Copy link
Member Author

Schrank commented May 29, 2015

hmm, I like the idea, will change it.

Schrank added 9 commits May 29, 2015 14:12
* development:
  add comment to now what this number is (DIN A4)
  add config path constant and helper method to get page size
  add admin setting and default for page size
  add page size source model
  implement method to get page size

# Conflicts:
#	src/app/code/community/FireGento/Pdf/Helper/Data.php
* development:
  fix missing translate attributes
  add all translations from XML files
  fixed Magento version in travis config
  added travis image to readme, fixes #228
  added travis configuration file, #228
  cleaned up german translation file and added missing strings
  ordered translation by name
  [~BUGFIX] break lines on whitespaces and dashes, #236
@Schrank Schrank closed this Jun 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants