Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swapped HardwareSerial for Stream in Firmata.cpp #173

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

swapped HardwareSerial for Stream in Firmata.cpp #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Firmata.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
//******************************************************************************

#include "Firmata.h"
#include "HardwareSerial.h"
#include "Stream.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So... I was going to suggest this: "What if you add some comment text here that simply says something like: "If you encounter a compilation exception error due to..." BUT then I realized they won't see this file open in the Arduino IDE and that is the crux of the problem. I think mitigation is insuperable. Does the Arduino IDE's new library system have any sort of "changelog" mechanism? Should it? (I suspect maybe?)


extern "C" {
#include <string.h>
Expand Down
1 change: 1 addition & 0 deletions examples/AllInputsFirmata/AllInputsFirmata.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*
* This example code is in the public domain.
*/
#include <HardwareSerial.h>
#include <Firmata.h>

byte pin;
Expand Down
1 change: 1 addition & 0 deletions examples/AnalogFirmata/AnalogFirmata.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
* This example code is in the public domain.
*/
#include <Servo.h>
#include <HardwareSerial.h>
#include <Firmata.h>

/*==============================================================================
Expand Down
1 change: 1 addition & 0 deletions examples/EchoString/EchoString.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
*
* This example code is in the public domain.
*/
#include <HardwareSerial.h>
#include <Firmata.h>

void stringCallback(char *myString)
Expand Down
1 change: 1 addition & 0 deletions examples/OldStandardFirmata/OldStandardFirmata.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
*/

#include <EEPROM.h>
#include <HardwareSerial.h>
#include <Firmata.h>

/*==============================================================================
Expand Down
1 change: 1 addition & 0 deletions examples/ServoFirmata/ServoFirmata.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
*/

#include <Servo.h>
#include <HardwareSerial.h>
#include <Firmata.h>

Servo servos[MAX_SERVOS];
Expand Down
1 change: 1 addition & 0 deletions examples/SimpleAnalogFirmata/SimpleAnalogFirmata.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
*
* This example code is in the public domain.
*/
#include <HardwareSerial.h>
#include <Firmata.h>

byte analogPin = 0;
Expand Down
1 change: 1 addition & 0 deletions examples/SimpleDigitalFirmata/SimpleDigitalFirmata.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
*
* This example code is in the public domain.
*/
#include <HardwareSerial.h>
#include <Firmata.h>

byte previousPIN[TOTAL_PORTS]; // PIN means PORT for input
Expand Down
1 change: 1 addition & 0 deletions examples/StandardFirmata/StandardFirmata.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@

#include <Servo.h>
#include <Wire.h>
#include <HardwareSerial.h>
#include <Firmata.h>

// move the following defines to Firmata.h?
Expand Down