Starting journey as a contributor #106751
Conversation
|
Hello @aaneesa, thank you for your pull request. We appreciate your contribution to the project. However, before we can merge it, there is a merge conflict with the target branch. No worries! You can follow this guide on resolving merge conflicts. If you have any questions or need further assistance, don't hesitate to reach out. We're here to help! |
|
Hello @aaneesa, thank you for your pull request. We appreciate your contribution to the project. However, before we can merge it, there is a merge conflict with the target branch. No worries! You can follow this guide on resolving merge conflicts. If you have any questions or need further assistance, don't hesitate to reach out. We're here to help! |
VuNguyen26
left a comment
VuNguyen26
left a comment
There was a problem hiding this comment.
Great PR! Code looks clean. Maybe consider adding comments for better readability.
| [Amohi Jain] (https://github.com/amohijain/first-contributions) | ||
| - [Aarav Jain](https://github.com/Aarav-Jain-official) | ||
| - [Amohi Jain](https://github.com/amohijain/first-contributions) | ||
| - [Anwesha](https://github.com/aaneesa) |
There was a problem hiding this comment.
Nice improvement! I think you could also consider simplifying this condition.
There was a problem hiding this comment.
Thanks for the feedback! I’ll look into simplifying it in the next update.
There was a problem hiding this comment.
@VuNguyen26, can you explain how to simplify the condition like you mentioned? How would you do it?
3 participants
No description provided.