-
Notifications
You must be signed in to change notification settings - Fork 73
日報の学習日入力部分に範囲バリデーションを追加した #8181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
202a5ab
レポートの日付部分にHTMLのバリデーションを追加
ayu-0505 b4cc2e3
モデルの日付バリデーションメソッドを基準日〜今日の範囲になるよう変更。動作確認用に一時的にHTMLバリデーションをコメントアウト
ayu-0505 6ef700c
作成したreportモデルのメソッドに単体テストを追加
ayu-0505 9c6fb12
不要になったコメントを削除
ayu-0505 4cb81b9
作成したバリデーションメソッドをprivate下に変更、対応する単体テストを削除
ayu-0505 4d0f5ac
今日の日付の日報が作れないバグを修正
ayu-0505 23c0023
関係している既存テストを修正、過去の基準日より古い日付で日報作成した際の確認テストを追加
ayu-0505 ffab652
過去の基準日当日も作成できるように修正
ayu-0505 08c0620
テストの文言を実態に沿うように修正
ayu-0505 c96eeed
システムテストの日報作成日付を過去の基準日前に変更、モデルバリデーションからHTMLバリデーションのチェックに変更
ayu-0505 6856332
メソッド名を変更、i18nにおける余分なformat指定を削除
ayu-0505 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
htmlによるバリデーションのテスト、このように書けるのですね😳
勉強になりました🙇♀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
もしかしたらもっと良い方法もあるかもしれませんが、現状ではこちらの方法で確認できていますね👀
よろしければ参考にしたサイトを載せておきます。
参考:https://qiita.com/paranishian/items/8d936b952b209fb8d8f0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
サイトも教えて頂きありがとうございます!🙏