Set device pixel ratio for grim screenshot #3604
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiolo
force-pushed
the
wayland-grim-pixmap-setdevicepixelratio
branch
from
71ae078 to
c80ed93
Compare
Grim returns a bitmap with the physical size of the screen. This needs to be scaled back to be displayed as underlay for Flameshot on screens where logical size differs from the physical size (i.e. scale is active). In order to do this, set the device pixel ratio, see <https://doc.qt.io/qt-5/qpixmap.html#setDevicePixelRatio>. Please note that this works only properly with integer scale. `QScreen::devicePixelRatio()` rounds when fractional scale is active on Wayland (because fractional scale is not yet supported by qtWayland).
tobiolo
force-pushed
the
wayland-grim-pixmap-setdevicepixelratio
branch
from
c80ed93 to
8f3c80f
Compare
|
Note: It should be this or #3606, but not both. |
|
What happens if fractional scaling is set? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grim returns a bitmap with the physical size of the screen. This needs to be scaled back to be displayed as underlay for Flameshot on screens where logical size differs from the physical size (i.e. scale is active).
In order to do this, set the device pixel ratio, see https://doc.qt.io/qt-5/qpixmap.html#setDevicePixelRatio.
Please note that this works only properly with integer scale. QScreen::devicePixelRatio rounds when fractional scale is active on Wayland.