Added possibility to have a secondary el on the host #219
+18
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change, relatively simple and backward compatible, enables syncing an external execution client from the host itself instead of relying on running within Docker. We tested it and to succesfully sync with the inner el peer, one further change is needed which is to expose the P2P address to the public interface (instead of only within the host), PR incoming for this.
There was a problem hiding this comment.
Pull request overview
This PR adds support for using a secondary execution layer (EL) client on the host machine instead of requiring it to run within Docker. The implementation changes the secondaryEL field from a port number to a string that accepts either a port or a full address, maintaining backward compatibility.
Key Changes:
- Modified
secondaryELfield fromuint64(port only) tostring(port or address) - Added regex-based logic to distinguish between port-only and full address inputs
- Updated documentation to explain both usage patterns (port vs full address)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change, relatively simple and backward compatible, enables syncing an external execution client from the host itself instead of relying on running within Docker. We tested it and to succesfully sync with the inner el peer, one further change is needed which is to expose the P2P address to the public interface (instead of only within the host), PR incoming for this.