Adding possibility to add more prefunded accounts #221
+48
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add possibility to add more prefunded accounts to the L1 generated genesis by accepting a repeated `[]string` flag `--prefunded-account` which accepts the same format (private key in hex) as the static prefunded accounts. I debated about putting the `prefunded-account` flag on the L1 recipe directly, to scope it just to this. Maybe it would be preferable, let me know what do you think.
There was a problem hiding this comment.
Pull request overview
This pull request adds the ability to specify additional prefunded accounts for L1 and L2 genesis configurations through a new --prefunded-account CLI flag. The flag accepts private keys in hexadecimal format and can be specified multiple times to add multiple accounts.
Key changes:
- New
--prefunded-accountflag that accepts private keys and can be repeated - Refactored static prefunded accounts into a separate variable positioned closer to usage
- Additional prefunded accounts are combined with the existing 10 static accounts in the genesis
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| playground/artifacts.go | Added prefundedAccounts field to ArtifactsBuilder, new setter method PrefundedAccounts(), helper method getPrefundedAccounts() to combine static and user-provided accounts, and moved static accounts definition for better code organization |
| main.go | Added prefundedAccounts global variable and --prefunded-account CLI flag, integrated the flag value with the artifacts builder |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Took the opportunity to document the prefunded
Collaborator
|
LGTM! |
Contributor
Author
|
@ferranbt Let me know how you want to proceed, will be happy to work any you like for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add possibility to add more prefunded accounts to the L1 generated genesis by accepting a repeated
[]stringflag--prefunded-accountwhich accepts the same format (private key in hex) as the static prefunded accounts.I debated about putting the
prefunded-accountflag on the L1 recipe directly, to scope it just to this. Maybe it would be preferable, let me know what do you think.