feat: add chain-monitor
#225
Open
+97
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julio4
force-pushed
the
feat/chain-monitor
branch
from
ae11b20 to
fa1ed4c
Compare
ferranbt
reviewed
Dec 9, 2025
| L2BlockTime string | ||
| L2BuilderAddress string | ||
| L2RPC string | ||
| ServerListenAddress string |
Collaborator
There was a problem hiding this comment.
Why do you need the ServerListenAddress field? It seems that it complicates the component and it is not used.
ferranbt
reviewed
Dec 9, 2025
| l2BlockTime := fmt.Sprintf("%ds", o.blockTime) | ||
|
|
||
| svcManager.AddService("chain-monitor", &ChainMonitor{ | ||
| L1RPC: Connect("el", "http"), |
Collaborator
There was a problem hiding this comment.
If possible and it is always the same, I prefer to use only the service name (el) and let the component call Connect itself.
ferranbt
reviewed
Dec 9, 2025
| }) | ||
|
|
||
| svcManager.MustGetService("chain-monitor"). | ||
| DependsOnHealthy("el"). |
Collaborator
There was a problem hiding this comment.
Why don't you define this DependsOnHealthy on the component?
ferranbt
requested changes
Dec 9, 2025
Collaborator
ferranbt
left a comment
ferranbt
left a comment
There was a problem hiding this comment.
Looks good - just a few questions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new
--chain-monitorflag for opstack recipe to bootstrap https://github.com/flashbots/chain-monitorUsing
0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266as builder signer for op-rbuilder