Fix: #138. Set temporary coinbase signer during backtesting if none found#215
Closed
danielhyk1 wants to merge 5 commits intoflashbots:developfrom
danielhyk1:fix/backtest-secret-temp-generate
Closed
Fix: #138. Set temporary coinbase signer during backtesting if none found#215danielhyk1 wants to merge 5 commits intoflashbots:developfrom danielhyk1:fix/backtest-secret-temp-generate
danielhyk1 wants to merge 5 commits intoflashbots:developfrom
danielhyk1:fix/backtest-secret-temp-generate
Conversation
danielhyk1
requested review from
ZanCorDX,
dvush,
ferranbt,
jakubhruby7 and
metachris
as code owners
Benchmark results for
|
| Date (UTC) | 2024-10-31T15:23:39+00:00 |
| Commit | bebc08fbfc6c726a39c376b649310b684ae4feac |
| Base SHA | 112fb17450f8e1b267fb0d38bad011830d92d1b9 |
Significant changes
None
Contributor
|
Hey, the CI has stopped. I cannot manage to trigger it again from my side :) Can you do a dummy commit to trigger it again? |
mralj
added a commit
to NethermindEth/rbuilder
that referenced
this pull request
Dec 26, 2024
Contributor
|
@danielhyk1 I'd love to get this merged. Would you please resolve the conflicts with |
Collaborator
|
made it draft until it's get fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Fixed #138. Creates and sets a private key as an environment variable if no valid COINBASE_SECRET_KEY is found during parsing. This is only within backtest and does not affect the live builder.
✅ I have completed the following steps:
make lintmake test