fix: don't build flashblocks with more gas than block gas limit #567
+121
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyalprout
commented
Apr 16, 2025
| @@ -512,7 +526,7 @@ where | |||
| &mut info, | |||
| &mut db, | |||
| best_txs, | |||
| total_gas_per_batch, | |||
| total_gas_per_batch.min(ctx.block_gas_limit()), | |||
There was a problem hiding this comment.
This technically isn't necessary given we skip building the flashblock if it's out of the expected bounds. However this seems like a sensible check to keep IMO
avalonche
approved these changes
Apr 16, 2025
danyalprout
force-pushed
the
fix-gas-limit
branch
from
af4444e to
5c04642
Compare
|
@avalonche would it be possible to run the CI please 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Currently it's possible for the builder to make more Flashblocks than intended during a block (likely due to delays). If more flashblocks are made than desired (e.g. 11 flashblocks for a 2s block w/ 200ms Flashblocks), the 11th flashblock will have a gas limit that is over the blocks gas limit and will cause invalid blocks on the sequencer.
💡 Motivation and Context
If the builder produces a full block that uses more gas than the gas limit, the local EL client will treat it as invalid.
✅ I have completed the following steps:
make lintmake test