Skip to content

MetaInfo: Don't start with an article - #291

Open
cassidyjames wants to merge 1 commit into
flathub:masterfrom
cassidyjames:patch-1
Open

MetaInfo: Don't start with an article#291
cassidyjames wants to merge 1 commit into
flathub:masterfrom
cassidyjames:patch-1

Conversation

@cassidyjames

Copy link
Copy Markdown
Member

One of the Flathub MetaInfo Quality Guidelines Chrome is currently failing is its summary starts with an article. These guidelines should be followed for improved display across Flathub.

This PR reworks the summary, adapting copy from the Chrome app listing for Android while:

  • Not repeating the developer name
  • Keeping it under 35 characters

One of the [Flathub MetaInfo Quality Guidelines][1] Chrome is currently failing is its summary starts with an article. These guidelines should be followed for improved display across Flathub.

This PR reworks the summary, adapting copy from the Chrome app listing for Android while:

- Not repeating the developer name
- Keeping it under 35 characters

[1]: https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/quality-guidelines
@flathubbot

Copy link
Copy Markdown
Contributor

Started test build 116432

@flathubbot

Copy link
Copy Markdown
Contributor

Build 116432 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/99248/com.google.Chrome.flatpakref

@Bohne13 Bohne13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goody, but would add 'by Google' or 'from Google'

To clarify the origin of the software.
Should be 35 characters or less.

@cassidyjames

cassidyjames commented Apr 23, 2024

Copy link
Copy Markdown
Member Author

The summary is not to communicate the developer or origin; that’s precisely what the <developer> (or deprecated <developer_name> as used here) tag is¹. In addition, the <name> already includes Google as well. So we don't need:

Google Chrome
by Google
Fast and easy web browser from Google

I think it’s clear it is from Google. 😅

¹https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#name-summary-and-developer-name

@refi64

refi64 commented May 6, 2024

Copy link
Copy Markdown
Collaborator

These files were taken from upstream (ditto for the one in Chromium), are these things that should be pushed up there as well?

@cassidyjames

Copy link
Copy Markdown
Member Author

@refi64 yeah that's fair; I've not contributed to Chromium so idk if I'll find the time to contribute that but it should definitely go upstream if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants