Update to the very latest nightly version of BlastEm and restrict home directory access#17
Update to the very latest nightly version of BlastEm and restrict home directory access#17techmetx11 wants to merge 4 commits intoflathub:masterfrom
Conversation
…emove home directory access
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
❌ Test build failed. Help
|
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
✅ Test build succeeded. To test this build, install it from the testing repository: Built for x86_64 architecture. Warnings can be promoted to errors in the future. Please try to resolve them.
|
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
✅ Test build succeeded. To test this build, install it from the testing repository: Built for x86_64 architecture. |
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
✅ Test build succeeded. To test this build, install it from the testing repository: Built for x86_64 architecture. |
|
CC @hadess |
| "modules" : [ | ||
| "shared-modules/glu/glu-9.json", | ||
| "shared-modules/glew/glew.json", | ||
| { |
| "paths" : [ | ||
| "0001-Add-support-for-Flatpak-config-data-dir-variables.patch" | ||
| "0001-Add-support-for-Flatpak-config-data-dir-variables.patch", | ||
| "0002-Integrate-a-native-file-chooser-into-BlastEm-using-X.patch" |
| { | ||
| "type": "git", | ||
| "url": "https://github.com/flatpak/libportal.git", | ||
| "commit": "086cc57372989117cfb6ef4c565bdd316db2e536" |
hadess
left a comment
hadess
left a comment
There was a problem hiding this comment.
We would definitely need to see separate patches (and reordering) for the build fixes, the version update, new dependencies, and applying the file chooser patch.
There's one big problem with this whole patch though, we only get access to the ROM file, and BlastEm expects to be able to access the directory the ROM is in to save the corresponding .SAV file when the game supports saves. This will be broken with this setup. What's the plan for fixing that?
| From 464bbad5dea3c481600b206f0bcaa5ace7861650 Mon Sep 17 00:00:00 2001 | ||
| From: techmetx11 <techmetx11@disroot.org> | ||
| Date: Mon, 2 Feb 2026 23:51:58 +0100 | ||
| Subject: [PATCH] Integrate a native file chooser into BlastEm using XDG |
There was a problem hiding this comment.
This patch is added in this commit, and then modified in a later commit. I'd much rather see a single commit that added the final version of the patch.
| "paths" : [ | ||
| "0001-Add-support-for-Flatpak-config-data-dir-variables.patch" | ||
| "0001-Add-support-for-Flatpak-config-data-dir-variables.patch", | ||
| "0002-Integrate-a-native-file-chooser-into-BlastEm-using-X.patch" |
There was a problem hiding this comment.
That patch is nice, but what's its upstream status? Is the maintainer going to review it/merge it soon? We would at least want a reference in the commit message.
4 participants
This PR updates the BlastEm's source archive to the very last commit made (as of the time of this PR)
Also, the program has been patched to use the XDG Desktop Portal file chooser and enable it by default within the program's settings, which means the program no longer requires read-only access to the user's home directory.