build-aux: Use GNOME 49 runtime for Gtk 3 example, too#207
Merged
GeorgesStavracas merged 1 commit intoflatpak:mainfrom Oct 9, 2025
Merged
build-aux: Use GNOME 49 runtime for Gtk 3 example, too#207GeorgesStavracas merged 1 commit intoflatpak:mainfrom
GeorgesStavracas merged 1 commit intoflatpak:mainfrom
Conversation
Contributor
|
Yes, because the window explicitly states "NEW VERSION": Since it wants us to use the GTK4 frontend, I didn't bother bumping the runtime for the GTK3 version. |
Contributor
Author
|
That's been there since several years before the Gtk4 example was added. I don't think it means "you should use the new version instead", I think it means something more like "this is the new version of the Gtk3 portal test (integrated into libportal), not the old version (a standalone app)". libportal should continue to have a Gtk 3 UI for as long as it has |
Contributor
|
Fair. I haven't tested this MR, but if it works, perhaps we can merge it? |
GeorgesStavracas
approved these changes
Oct 9, 2025
Signed-off-by: Simon McVittie <smcv@debian.org>
58bb3e9 to
d423e28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@TheEvilSkeleton, was there a reason you didn't do this already in #206?