Add clipboard API and new input capture session construction API by jadahl · Pull Request #208 · flatpak/libportal

jadahl · 2025-11-20T22:52:50Z

This adds clipboard API usable with the existing remote desktop portal, and implements the new split session construction input capture API, as well as input capture clipboard support. See flatpak/xdg-desktop-portal#1803.

This makes the label not "fly away" when some other widget makes its column wider.

Only starts the session and reports the shared devices and streams.

This will be necessary when handling signals, which needs to fetch the session from a handle.

This adds API to interact with the clipboard portal associated with a remote desktop session.

This allows copying to, and pasting from, the clipboard portal.

This makes it easier to construct a session from somewhere else, which will be needed with CreateSession2().

It's its own thing, that also controls the lifetime of the actual session, so need some special casing.

Rather useless, since we're not adding any barriers, but more complete none the less.

In API version 2, the CreateSession() was replaced by CreateSession2()/Start(); add API that corresponds to this. Unfortunately applications will need to check whether this is supported by manually checking the exposed API version, to use the new construction method.

This will allow enabling clipboard integration later.

whot

Note that one of the commit messages has a portal--test/ prefix

whot · 2026-02-25T04:52:50Z

libportal/clipboard.c

+}
+
+/**
+ * xdp_session_is_clipboard_enabed:


Suggested change

* xdp_session_is_clipboard_enabed:

* xdp_session_is_clipboard_enabled:

whot · 2026-02-25T04:53:20Z

libportal/clipboard.c

+{
+  XdpPortal *portal = data;
+  XdpSession *session;
+  g_autoptr(GVariant) variant = NULL;


Suggested change

g_autoptr(GVariant) variant = NULL;

unused

whot · 2026-02-25T04:53:37Z

libportal/clipboard.c

+                         mime_type, serial);
+}
+
+void


Suggested change

void

static void

whot · 2026-02-25T04:54:00Z

libportal/clipboard.c

+                                                   &error);
+  if (!ret)
+    {
+      g_warning ("Failed to write selection: %s", error->message);


Suggested change

g_warning ("Failed to write selection: %s", error->message);

g_warning ("Failed to read selection: %s", error->message);

whot · 2026-02-25T04:54:35Z

libportal/clipboard.c

+                          PORTAL_BUS_NAME,
+                          PORTAL_OBJECT_PATH,
+                          "org.freedesktop.portal.Clipboard",
+                          "SetSelection",


Suggested change

"SetSelection",

"SelectionWriteDone",

whot · 2026-02-25T04:55:15Z

libportal/inputcapture.c

+  if (!call->session_path)
+    {
+      g_task_return_new_error (call->task, G_IO_ERROR, G_IO_ERROR_FAILED,
+                               "Missing session handel");


Suggested change

"Missing session handel");

"Missing session handle");

whot

A few nitpicks after a manual review, but overall this LGTM

whot · 2026-02-25T05:19:34Z

portal-test/gtk3/portal-test-win.c

+      g_autoptr(GString) devices_s = NULL;
+
+      if (s->len > 0)
+        g_string_append (s, "\n");
+
+      devices_s = g_string_new (NULL);
+      g_string_append (s, "Devices: ");
+
+      if (device_types & XDP_DEVICE_KEYBOARD)
+        g_string_append (devices_s, "keyboard");
+
+      if (device_types & XDP_DEVICE_POINTER)
+        {
+          if (devices_s->len > 0)
+            g_string_append (devices_s, ", ");
+          g_string_append (devices_s, "pointer");
+        }
+
+      if (device_types & XDP_DEVICE_TOUCHSCREEN)
+        {
+          if (devices_s->len > 0)
+            g_string_append (devices_s, ", ");
+          g_string_append (devices_s, "touchscreen");
+        }


I reckon this would be easier to read with a GStrv and a g_strjoin() or whatever it's called.

whot · 2026-02-25T05:38:05Z

libportal/inputcapture.h

+                                                      gpointer             data);
+
+XDP_PUBLIC
+XdpInputCaptureSession * xdp_portal_create_input_capture_session2_finish (XdpPortal     *portal,


just ftr, it'd be nice to also have this as _sync, feel free to steal that from #214

whot · 2026-02-25T05:40:18Z

libportal/portal-private.h

  /* background */
  guint background_interface_version;
+
+  /* clipbord */


Suggested change

/* clipbord */

/* clipboard */

whot · 2026-02-25T05:42:17Z

portal-test/gtk3/portal-test-win.c

+		    "width", &w,
+		    "height", &h,
+		    "x", &x,
+		    "y", &y,
+		    NULL);


this looks like wrong indentation here

whot · 2026-02-25T05:43:02Z

portal-test/gtk3/portal-test-win.c

-                                           win);
+  if (xdp_portal_get_input_capture_version_sync (win->portal, NULL, NULL) > 1)
+    {
+      g_print ("Using new input capture session construction API\n");


leftover debug statement?

whot · 2026-02-25T05:43:08Z

portal-test/gtk3/portal-test-win.c

+    }
+  else
+    {
+      g_print ("Using legacy input capture session construction API\n");


whot · 2026-02-26T04:30:59Z

yikes, another issue: the first two commits for portal-test/gtk3 need to be ordered after Add clipboard API, they make use of the clipboard api and won't build in this order.

Anyway, I've squashed all the above comments into my branch in #214 so might be easiest to get that one merged.

sithlord48 · 2026-03-21T12:38:32Z

I've squashed all the above comments into my branch in #214 so might be easiest to get that one merged.

This has been replaced by #214 this one can be closed

jadahl added 3 commits November 20, 2025 16:24

portal-test/gtk3: Set screencast label halign to 'start'

a32a0ba

This makes the label not "fly away" when some other widget makes its column wider.

portal-test/gtk3: Add remote desktop support

c47f9ad

Only starts the session and reports the shared devices and streams.

portal: Keep track of sessions

bef6716

This will be necessary when handling signals, which needs to fetch the session from a handle.

jadahl mentioned this pull request Nov 20, 2025

Add clipboard support to the input capture portal flatpak/xdg-desktop-portal#1803

Merged

jadahl added 8 commits November 21, 2025 09:48

Add clipboard API

cd4a9a8

This adds API to interact with the clipboard portal associated with a remote desktop session.

portal-test/gtk3: Add clipboard portal knobs

171165f

This allows copying to, and pasting from, the clipboard portal.

input-capture: Fold connecting to signals into session constructor

cc98fc0

This makes it easier to construct a session from somewhere else, which will be needed with CreateSession2().

portal-test/gtk3: Track input capture session separately

03c773f

It's its own thing, that also controls the lifetime of the actual session, so need some special casing.

portal-test/gtk3: Hook up input capture enable/disable

5e469b4

Rather useless, since we're not adding any barriers, but more complete none the less.

portal--test/gtk3: Use split input capture session constructors

81ba95c

This will allow enabling clipboard integration later.

portal-test/gtk3: Enable input capture clipboard integration

efa8c1a

jadahl force-pushed the wip/input-capture-clipboard branch from bfc4532 to efa8c1a Compare November 21, 2025 08:48

whot mentioned this pull request Feb 25, 2026

InputCapture support for session persistence #214

Open

whot reviewed Feb 25, 2026

View reviewed changes

whot approved these changes Feb 25, 2026

View reviewed changes

	* xdp_session_is_clipboard_enabed:
	* xdp_session_is_clipboard_enabled:

	g_warning ("Failed to write selection: %s", error->message);
	g_warning ("Failed to read selection: %s", error->message);

Conversation

jadahl commented Nov 20, 2025

Uh oh!

whot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

whot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

whot commented Feb 26, 2026

Uh oh!

sithlord48 commented Mar 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants