-
Notifications
You must be signed in to change notification settings - Fork 14
Alec/photothermal #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alec/photothermal #393
Conversation
Spell Check ReportPhotoThermalWaveguides.ipynb: Checked 1 notebook(s). Found spelling errors in 1 file(s). |
FilipeFcp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Alec, that’s a pretty cool notebook.
Everything is very clear; I just have a few minor comments.
It seems the image wasn’t uploaded.
Last line of the introduction: “siginal waveguide's phase change” → “signal waveguide's phase change”
Below cell 21: “the the control” → “the control”
|
Everything should be addressed, thanks for the feedback and help! |
tomflexcompute
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alec-flexcompute for the great addition.
It seems like the notebook doesn't involve any mode solving so Mode analysis probably doesn't need to be included in the features list?
|
Good catch! Fixed. |
No description provided.