-
Notifications
You must be signed in to change notification settings - Fork 14
uploading APD example #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Spell Check ReportAvalanchePhotodiode.ipynb: Checked 1 notebook(s). Found spelling errors in 1 file(s). |
tomflexcompute
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FilipeFcp and @marc-flex on making this possible. A few comments:
- "Photodiode" on the title -> "photodiode"
- In the beginning, add a brief overall introduction about avalanche photodiode
- This is more for @marc-flex , can we add some convenient functions to calculate the optical absorption to reduce the codes in cell[12]?
- Explain a little bit on the physics of dark and bright currents as well as what the final result implies.
marc-flex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FilipeFcp for turning my draft into this nice notebook! I left some minor comments (most of which are my fault to begin with). It'd also be good if @momchil-flex could have a quick look
- In cell 2 I left a T0 = 280. I think it is safe to just use 300. Either way we should probably only leave 1 to avoid confusion.
- In cell 3 maybe remove comments (e.g.,
alpha_n_inf=7.03e5/8000,) that I used to try things out. Actually, I left a lot of comments scattered throughout the notebook. So sorry about it - in cell 20 I'd change the comment to say that we're only visualizing the x component of the electric current. As an alternative we could compute the modulus of the current density vector and plot that instead?
- In cell 21 maybe add label for the x axis? i.e., applied bias
We should definitely think of something, especially as we add more other effects such as the TPA that @momchil-flex has been working on. |
Hi all,
I’ve added some text and the image.
The mode simulation looks good, I ran a few tests, and the results seem quite solid. It’s a bit different from what’s shown in the paper, but if I understood correctly, they simulate the coupling from the Si waveguide into the Ge region. Nevertheless, the results for the photocurrent appear consistent.
The main discrepancy occurs around 11 V, which seems to correspond to the breakdown voltage. But I couldn't figure out why.