fix(rf): FXC-3877 more robust suppression of RF license warning

[dmarek-flex]

Greptile Overview

Updated On: 2025-10-29 01:51:19 UTC

Greptile Summary

Replaces the brittle is_running_pytest() function (which checked for pytest in sys.modules) with a more explicit environment variable-based approach. The RF license warning is now suppressed during tests via TIDY3D_MICROWAVE__SUPPRESS_RF_LICENSE_WARNING=true in pytest config.

Key changes:

• Deleted tidy3d/utils.py entirely (contained only the is_running_pytest() helper)
• Updated MicrowaveBaseModel to use config.microwave.suppress_rf_license_warning instead of the deprecated flat config path
• Added TIDY3D_MICROWAVE__SUPPRESS_RF_LICENSE_WARNING=true to pytest environment variables in pyproject.toml
• Fixed typo: default_contructed → default_constructed

Benefits:

• More explicit control over warning suppression
• Works consistently across different test environments
• Leverages the existing config system's environment variable parsing

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The changes are well-structured, properly tested, and improve the robustness of test warning suppression. The typo fix is a bonus improvement. All changes are backwards compatible through the legacy config wrapper.
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
CHANGELOG.md	5/5	Added changelog entry for more robust RF license warning suppression
pyproject.toml	5/5	Added environment variable to suppress RF license warnings during pytest runs
tidy3d/components/microwave/base.py	5/5	Removed is_running_pytest() check, fixed typo (contructed -> constructed), updated to use config.microwave.suppress_rf_license_warning
tidy3d/utils.py	5/5	File deleted - contained only the now-unused is_running_pytest() function

Sequence Diagram

sequenceDiagram
    participant Pytest
    participant EnvLoader as ConfigLoader.load_environment_overrides()
    participant Config as config.microwave
    participant MWBase as MicrowaveBaseModel
    participant Logger as log.warning()

    Note over Pytest: pytest starts with env var:<br/>TIDY3D_MICROWAVE__SUPPRESS_RF_LICENSE_WARNING=true
    
    Pytest->>EnvLoader: Parse TIDY3D_* environment variables
    EnvLoader->>Config: Set suppress_rf_license_warning = True
    
    Note over MWBase: User instantiates MicrowaveBaseModel subclass
    MWBase->>MWBase: _warn_rf_license() validator runs
    MWBase->>Config: Check config.microwave.suppress_rf_license_warning
    
    alt suppress_rf_license_warning == True
        Config-->>MWBase: True (suppressed)
        Note over MWBase: Skip warning
    else suppress_rf_license_warning == False
        Config-->>MWBase: False
        MWBase->>Logger: Emit RF license warning
    end
    
    Note over MWBase: Alternative: _default_without_license_warning()
    MWBase->>Config: Temporarily set suppress_rf_license_warning = True
    MWBase->>MWBase: Instantiate cls()
    MWBase->>Config: Restore suppress_rf_license_warning = False

Loading

[greptile-apps]

_{4 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[github-actions]

Diff Coverage

Diff: origin/develop...HEAD, staged and unstaged changes

• tidy3d/components/microwave/base.py (100%)

Summary

• Total: 6 lines
• Missing: 0 lines
• Coverage: 100%

[yaugenst-flex]

Thanks @dmarek-flex LGTM!