Update readme to handle unsupported devise routes#1
Open
jimmynguyc wants to merge 2 commits intoflexnode:masterfrom
Open
Update readme to handle unsupported devise routes#1jimmynguyc wants to merge 2 commits intoflexnode:masterfrom
jimmynguyc wants to merge 2 commits intoflexnode:masterfrom
Conversation
Member
|
The gem doesn't have devise as a dependency .. any idea of a better solution? |
Author
|
Ah you're right .. I thought it was dependent. I mean it's not the concern of this gem already I think if devise is not a dependancy. Maybe just a note. I'll make an update. As for the scope you're doing it throught |
Author
|
Ended up being a huge "note" 💃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default devise routes shouldn't be usable. If we don't do this then the default devise routes are accessible directly, and it will not follow the SSO flow.
Also because we're not doing
config.omniauth :xxxxxxxinconfig/devise.rb. It will not includeDevise::OmniAuth::UrlHelpersan therefore you'll have problems when you access the default Devise templates that containsomniauth_authorize_path(resource_name, provider)